septh / vscode-wow-bundle Goto Github PK

Hello @Septh! First of all, great repo!

I'd love to have a current, working version of this extension, and I noticed that the 2.0 branch has seen no activity in almost a year. I'd love to help if I could, even maintaining a classic branch for us folks who do play in the 1.13 client.

Can I do anything to help? Or have you abandoned the project at this point? In that case I'd fork and maintain my own copy

Got this installed. I don't see what it does though. It says it has the full WoW API, but when I attempt to type function names and stuff that are in the WoW API I don't see any sort of autocomplete or anything like that.

Also I don't see any sort of code hints. For example when I type SendChatMessage( I would expect to see a hint that tells me the parameters that are to be used, etc.

So what am I misunderstanding here?

Noticed this on the information page. While the files were removed the data was moved into the Blizzard_APIDocumentation folder..
https://www.townlong-yak.com/framexml/live
Warning

With WoW 7.3, Blizzard removed the 3 files I used to maintain wow-bundle (namely GlobalAPI.lua, WidgetAPI.lua and Events.lua from the Helix directory). Therefore, I cannot guarantee any longer that the bundle is 100% accurate with respect to the lastest WoW API.

Some if the info in there is the following..

local AreaPoiInfo =
{
Name = "AreaPoiInfo",
Type = "System",
Namespace = "C_AreaPoiInfo",

Functions =
{
{
Name = "GetAreaPOIForMap",
Type = "Function",

  Arguments =
  {
    { Name = "uiMapID", Type = "number", Nilable = false },
  },

  Returns =
  {
    { Name = "areaPoiIDs", Type = "table", InnerType = "number", Nilable = false },
  },
},
{
  Name = "GetAreaPOIInfo",
  Type = "Function",

  Arguments =
  {
    { Name = "uiMapID", Type = "number", Nilable = false },
    { Name = "areaPoiID", Type = "number", Nilable = false },
  },

  Returns =
  {
    { Name = "poiInfo", Type = "AreaPOIInfo", Nilable = false },
  },
},
{
  Name = "GetAreaPOITimeLeft",
  Type = "Function",

  Arguments =
  {
    { Name = "areaPoiID", Type = "number", Nilable = false },
  },

  Returns =
  {
    { Name = "minutesLeft", Type = "number", Nilable = false },
  },
},
{
  Name = "IsAreaPOITimed",
  Type = "Function",
  Documentation = { "This statically determines if the POI is timed, GetAreaPOITimeLeft retrieves the value from the server and may return nothing for long intervals" },

  Arguments =
  {
    { Name = "areaPoiID", Type = "number", Nilable = false },
  },

  Returns =
  {
    { Name = "isTimed", Type = "bool", Nilable = false },
  },
},

},

Events =
{
{
Name = "AreaPoisUpdated",
Type = "Event",
LiteralName = "AREA_POIS_UPDATED",
},
},

Tables =
{
{
Name = "AreaPOIInfo",
Type = "Structure",
Fields =
{
{ Name = "areaPoiID", Type = "number", Nilable = false },
{ Name = "position", Type = "table", Mixin = "Vector2DMixin", Nilable = false },
{ Name = "name", Type = "string", Nilable = false },
{ Name = "description", Type = "string", Nilable = true },
{ Name = "textureIndex", Type = "number", Nilable = true },
{ Name = "widgetSetID", Type = "number", Nilable = true },
{ Name = "atlasName", Type = "string", Nilable = true },
},
},
},
};

APIDocumentation:AddDocumentationTable(AreaPoiInfo);

so this table here, I don't quite understand the coloring here. sort is probably just different because it's a keyword but the different string colors? Please enlighten me :)

...again. Not sure if this even concerns you in the slightest, but the original Lua TextMate bundle has been getting a few improvements lately, after 3 years of neglect, maybe there is something interesting for you in there, too? Anyway, have a looksie https://github.com/textmate/lua.tmbundle/commits/master

So, 8.0 just came out and I was wondering if there were plans on updating this extension anytime soon.

I'd love to help work on it, but I'm not very familiar with extension development.
If there is anything I can do to help, I'd love to.... but with my lack of knowledge I'd need at least a starting point.

Thanks again for this great extension!

It seems like the detection of invalid ignores the fact that I have reassigned them and still colors them as invalid, is there any way to disable invalid coloring?

For example I use local tinsert = table.insert all the time because I'm so used to the shorter version and it works fine but it is always flagged as invalid with your extension.

I'm having a problem with the Dark+ (WoW) theme.

On your example, the black text is actually white, which makes sense because black on dark background is strange xD
I went to check if I could find the reason and fix it/commit before I came here but I honestly don't see anything with the code for black or very dark.

btw, i'm making some snippets for personal use (some general lua and some more for addons), if you want i can send them after for you to include on the extension.

Thank you for your work.

does it support 3.3.5? its a pretty popular version ( I mean the original one, not the new classic one).

I'm maintaining a list of API, widgets and events for 8.1.5
https://github.com/Ketho/BlizzardInterfaceResources

Is there way you could update the resources with this list or should I make a pull request? But to be honest, I'm not familiar with the workings of vscode extensions.

Is it possible to add changing the lineHighlight color for any of the color themes? I'mnot a fan of the box outline and would prefer a solid color. Thank you.

Currently folding is broken by multi-line strings, i.e. strings of the form:

[[My
Multiline
String]]

This is exacerbated by the fact that many of my multiline strings contain Lua code to be run in-game.

An example from code that is broken:

            ["102"] = {
                name = "Vehicle",
                priority = 1000,
                condition = "return UnitUsingVehicle(\"player\");",
                events = {"UNIT_ENTERED_VEHICLE", "UNIT_EXITED_VEHICLE"},
            },
            ["200"] = {
                name = "Hearth/Teleport",
                priority = 20,
                condition = [[for k,v in pairs(this.spells) do
    if (UnitCastingInfo("player") == GetSpellInfo(v)) then
        return true;
    end
end
return false;]],
                executeOnInit = "this.spells = {227334, 136508, 189838, 54406, 94719, 556, 168487, 168499, 171253, 50977, 8690, 222695, 171253, 224869, 53140, 3565, 32271, 193759, 3562, 3567, 33690, 35715, 32272, 49358, 176248, 3561, 49359, 3566, 88342, 88344, 3563, 132627, 132621, 176242, 192085, 192084, 216016};",
                executeOnEnter = "local _, _, _, _, startTime, endTime = UnitCastingInfo(\"player\");\nthis.transitionTime = ((endTime - startTime)/1000) - .25;",
                events = {"UNIT_SPELLCAST_START", "UNIT_SPELLCAST_STOP", "UNIT_SPELLCAST_SUCCEEDED", "UNIT_SPELLCAST_CHANNEL_START", "UNIT_SPELLCAST_CHANNEL_STOP", "UNIT_SPELLCAST_CHANNEL_UPDATE", "UNIT_SPELLCAST_INTERRUPTED"},
            },

I think the best solution is just to have the multi-line string be foldable. though I'm not 100% on the implementation.

The progress on this extension seem to be somewhat lacking as of late for whatever reason. I know life gets busy and people get bored etc... but I've been using it exlusivly (althought probably not in the best ways) for developing my own addon.

If help is wanted I would be more than willing to give it a shot. Although I don't have my extension experience I do learn pretty quck, especially if I'm pushed in the right direction with decent doumention and by setting up some goals.

I'f you need any help getting a few more of those lacking feaures being working on I'd be happy to look into them as I would make my life easier in the long run.

Hit me up if you're interested. Maybe I could start somewhere small just t get an idea how everything is working and use other extensions to bring in some of the features you'll looking for by using them as a reference.

Thanks and keep up the good work!