Comments (7)
Why not. We haven't needed something like this so far but it's not a big burden to add and maintain. Is it something you need in your projects?
from euclid.
yes, I'm using an inclusive contains. Basically to detect if the cursor is on top of a region, but the cursor snaps to a grid.
I've since impl'd this in a trait extension and it works really well, but perhaps others may find this useful as well
from euclid.
I have written something similar, except that instead of just creating an inclusive version of contains
I have associated functions:
pub trait BoxInclusive {
type Point;
fn new_inclusive(min: Self::Point, max: Self::Point) -> Self;
fn from_points_inclusive<I>(points: I) -> Self
where
I: IntoIterator,
I::Item: Borrow<Self::Point>;
}
These simply create a normal box, then extend the max
point by one in every dimension so that the max
point itself is contained.
EDIT: I just submitted a PR for something unrelated, so I already have the project forked. I'd be happy to issue another PR for these inclusive box methods if there is interest from the maintainers in adding them to the box types directly.
from euclid.
I'm happy to take a PR for this if you want to make one.
from euclid.
These simply create a normal box, then extend the
max
point by one in every dimension so that themax
point itself is contained.
This sounds very much like what I did, but wouldn't it be better to just have contains_inclusive functions with the >
replaced with >=
from performance and aesthetics considerations?
from euclid.
I have a need to create and use inclusive boxes without even necessarily ever using the contains
method. Whatever approach the maintainers prefer is what we should go with.
from euclid.
Adding contains_inclusive
sounds good to me.
from euclid.
Related Issues (20)
- Fails to compile with --no-default-features HOT 2
- Vector missing the Sum trait HOT 3
- Support for numeric casts through `az` crate HOT 2
- Constructors: splat, one HOT 3
- Component-wise multiplication for Vector2 HOT 2
- Component-wise division for Vector2 HOT 2
- Support for bytemuck Pod and Zeroable HOT 2
- Distinguish between orientation and rotation.
- missing `AddAssign` impl for `SideOffsets2D` HOT 1
- Add tags for releases on crates.io HOT 1
- Implement more `num-traits` (e.g. checked arithmetic) HOT 2
- Poor accuracy in Vector2D::angle_from_x_axis HOT 1
- Scale `mod`, `div` by scalar HOT 3
- Unresolved Import `num_traits::Euclid` HOT 3
- Point2D/Point3D missing Add<Point2D<T, U>> impl HOT 1
- Add splat function for SideOffsets2D HOT 1
- The `from_points` for `Box2D` and `Box3D` does not work quite as advertised. HOT 2
- Documentation of Transform2D does not reflect the actual calculation HOT 1
- `Rotation2D` does not implement `Debug` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from euclid.