setono / deployer-cron Goto Github PK

When deploying two stages in parallel on the same server with the same user, the resulting crontab can be overwritten by the job that finishes last.

To fix this we should put a 'cron lock' that makes sure that only one process can edit the crontab at a time

Hi,

Have you planned to make it compatible with Deployer 7.X ?

Hi

Thanks for this deployer addon, really helpful!

I just set it up in a local project and wanted to put the jobs.yaml into the root directory instead of cluttering the project setup with an etc/* folder that wouldn't be used otherwise – most of the configs, like the deployer configuration files, are in the project root anyways.

I discovered that the deployment always failed because deployer-cron tried to load any file from the configured directory; .sql, .md, other .yml files, etc. I think it would be a better solution to either have a fixed filename or some sort of resolver for files that is restricting to certain file types. Loading SQL files wouldn't be a use case in the real world anyway.