setono / syliusanalyticsplugin Goto Github PK

https://github.com/BitBagCommerce/SyliusAnalyticsPlugin/tree/master/src/Resources/config/validation

Hi,

Thanks for the great Plugin, it worked immediately.
One thing, that I am missing is a guide how to add the checkout steps to google analytics.

'ec:setAction','checkout', {
    'step': 1,
    'option': 'xxx'

Some places you have used Analytics, some places Analytic. Use Analytics.

What do you think about using https://github.com/Setono/TagBagBundle instead to inject the scripts?

Put the contents of this file: https://github.com/BitBagCommerce/SyliusAnalyticsPlugin/blob/master/src/Resources/config/routing/admin/GoogleAnalyticConfig.yml into this file: https://github.com/BitBagCommerce/SyliusAnalyticsPlugin/blob/master/src/Resources/config/routing/admin.yml

It should be possible to add a tracking id for each channel.

In my opinion the GoogleAnalyticConfig.orm.xml should have a channel field and the trackingId field should not be nullable. You should then validate that a channel can only have one tracking id which means the ORM config should have a unique constraint like (channel, trackingId).

If it's done this way it would also be easier to add multiple tracking ids in the future for a channel if a customer wants that.

We have next error while running behat tests on one of our private projects (E...000):

Notice: Undefined index: search in vendor/setono/sylius-analytics-plugin/src/EventListener/ViewSearchResultsEventListener.php line 25 (see

So we should add some check there.

I really like subscribers in the sense that all you need to know is in the same class. With listeners you have to check the service definition together with the listener. Especially with some many listeners in this plugin it's tedious :)

What do you think?

Plugin version

v1.0.0-alpha.6 # "reference": "b935843102724489cd92224a5a0657648cfa23e6"

Sylius version

"version": "v1.11.15", "reference": "61494235eddb173c032eb5548d69fd1035b289c9"

What happened?

Hi , I've installed this plugin , configured well based on docs , migration script was executed , routes path etc & created new property under GA configured GA ID along with API secret in admin panel . BUT it just trigger only page view & checkout begin triggers & following triggers are missing .

• add_shipping_info
• add_to_cart
• begin_checkout
• purchase
• view_cart
• view_item_list
• view_item

this is how my setono_sylius_analytics.yaml looks like .
setono_google_analytics:
gtag: ~
# If you want to use tag manager instead of gtag, just comment the line above and remove the comment below
# tag_manager:

can any one help me if I'm missing missing ?
thanks in advance

Relevant log output

No response

https://github.com/BitBagCommerce/SyliusAnalyticsPlugin/blob/master/UPGRADE-1.3.md

Installed

composer require setono/sylius-analytics-plugin

Config

<?php
# config/bundle.php
return [
    ...
    Setono\TagBagBundle\SetonoTagBagBundle::class => ['all' => true],
    Setono\SyliusAnalyticsPlugin\SetonoSyliusAnalyticsPlugin::class => ['all' => true],
    Sylius\Bundle\GridBundle\SyliusGridBundle::class => ['all' => true],
];

# config/routes/setono_sylius_analytics.yaml
setono_sylius_analytics:
    resource: "@SetonoSyliusAnalyticsPlugin/Resources/config/routing.yaml"

# config/packages/_sylius.yaml
imports:
   ...
    - { resource: "@SetonoSyliusAnalyticsPlugin/Resources/config/app/config.yaml" }

Symptom

When I execute php bin/console doctrine:migrations:diff I get the following error:

$ php bin/console doctrine:migrations:diff

In ParameterBag.php line 100:
                                                                                               
  You have requested a non-existent parameter "setono_sylius_analytics.model.property.class".  

Describe the proposed solution

Update the readme. The current readme is for v2

Here: https://github.com/BitBagCommerce/SyliusAnalyticsPlugin/tree/master/spec

https://github.com/BitBagCommerce/SyliusAnalyticsPlugin/blob/master/src/Form/Type/GoogleAnalyticConfigType.php#L17 ?

A config menu item should (obviously) be under Configuration in the admin menu: https://github.com/BitBagCommerce/SyliusAnalyticsPlugin/blob/master/src/Menu/AnalyticsMenuBuilder.php