sflagp / qbxml-object-models Goto Github PK

Hello Greg,

I have been busy with a few other things and wasn't able to test the previous build. During my work, while applying filters on invoices on ModifiedDate, I found that it never parses the time part from a DateTime to XML but only parses the date.
The expected date format is:
yyyy-MM-ddTHH:mm:sszzz

Currently implemented as below:

Hello Grey,

I found a typo while working with invoice Line items.

[XmlElement("DataExtRet")] public List<DataExtRetDto> DateExtRet { get; set; }

The variable DateExtRet should be renamed to DataExtRet

Thank you <3

I see there's a DataExtRetDto, but is this for return data only? What if I want to send extended key/value pairs to QuickBooks for both Invoice and InvoiceLine? They would need to be a list of DataExtRqDto objects of something of the like.

Hello, Your work is appreciated. I loved it. well detailed.

May I know if there is a way to make batch requests by converting your objects into xml?

Hello Greg,

Found a property that is missing inside CustomerRetDto Model.
Property name is: TaxRegistrationNumber

For Reference:
https://developer.intuit.com/app/developer/qbdesktop/docs/api-reference/qbdesktop/customerquery

Hello Greg,

Seems some models are missing in the Library. I don't see any model to make the following query and handle the response.
https://developer.intuit.com/app/developer/qbdesktop/docs/api-reference/qbdesktop/iteminventoryassemblyquery

Would be a great help if you could implement and push the release.

Thank you

Hello Greg,

IncludeRetElement propertly should be of type List. Because this may repeat.

For reference: https://developer.intuit.com/app/developer/qbdesktop/docs/api-reference/qbdesktop/customerquery

The DataExtRet property does not exist for the SalesOrder itself. This property does exist in the SalesOrderLineRetDto. The latter is a
List<QbModels.DataExtRetDto> which is also appropriate for the SalesOrder.

The company file I'm working with has custom fields tied to both the Sales Order, and the Sales Order Lines.

Any chance we could get this property added? I don't mind creating a pull request, but it seems like a fairly quick addition. Just let me know if you'd prefer the pull request.

Great library - thank you!
Danny

Hello Greg,

I'm using QueryRq for the Models. I noticed that MaxReturned is not parsed to xml if we provide ModifiedDate etc or Name.

May I know the reference for this?

     [QbXmlOrder(200)]
    [XmlElement("MaxReturned")]
    public int? MaxReturned
    {
        get
        {
            if (ListID != null || FullName != null || ActiveStatus != null || FromModifiedDate.HasValue || ToModifiedDate.HasValue)
            {
                return null;
            }

            return maxReturned;
        }
        set
        {
            maxReturned = value;
        }
    }
    ```

Hello,

I noticed one more issue which is related to ShipToAddress inside CustomerRetDto Model. The ShipToAddress must be a list instead of object.
Official Docs says there could be around 50 addresses.
https://developer.intuit.com/app/developer/qbdesktop/docs/api-reference/qbdesktop/customerquery

Would that be possible for you to directly publish the change? Or it takes time?