sfu-dhil / wilde Goto Github PK

Describe the bug

The Image gallery is not displaying correctly. When I view the page in Safari and in Chrome, some images are displaying twice. In Safari, moreover, the image cards are not displaying in a uniform way.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...' Wilde Trials Home page
2. Click on '....' About
3. Scroll down to '....' Image Gallery
4. See error.

Expected behavior
I expect the page to show a uniform grid of cards and not to display some of these images in duplicate.

Screenshots

Desktop (please complete the following information):
Mojave 10.14.6
Chrome & Safari

Additional context
Add any other context about the problem here.

It looks like there is a bug with the drop-down arrow next to about and reports in the top menu bar. A double arrow is showing.

This is now a topic of discussion rather than an issue I would say. Colette shared that she still waits 17 second for the table to load. Therefore we need to think about how to best address this.

JT had proposed that we provide access to data on multiple pages (one page for each of the different "sorting" criteria used on the current page). In discussing with Colette on Skype she's also opened to the idea of using a dynamic search mechanism on the page. So instead of using sorting or whatnot a user would perform a search. Would staticized data be possible here? Iwas impressed by how fast that is.

Describe the bug
"Levenshtein" does not need to me named on this Comparison page (paragraphs).

Additionally the "Match: xx% Levenshtein" text is a bit hard to differentiate from the paragraph text. Can a bit more spacing be added between it and the paragraph text. (I am open to other ideas too).

To Reproduce
Steps to reproduce the behavior:

1. Go to 'All Reports"
2. Click on a Link that has paragraph matches
3. Open up a match button
4. Select Compare
5. You will see the Comparison page

Expected behavior
All we need to see is "Match: xx%" rather than "Match: xx% Levenshtein"

Screenshots
Here is a link to a sample page
https://dhil.lib.sfu.ca/wilde/compare.html?a=eja_1537&b=sara_1884

Describe the bug

This is not really a bug. I think a bit of explanatory text can be removed from the individual reports page template, which I think is called view.

In the document matches panel, I think we can remove "Levenshtein Matches." We are now just using Levenshtein, so I don't think we need to mention it here. Also, the documentation and my Curatorial Statement page explain that the match measure we use is Levenshtein.

If you agree, therefore, I think we can remove "Levenshtein Matches"

To Reproduce
Steps to reproduce the behavior:

1. Go to 'All Reports'
2. Click on Any link to a report that has document matches.'
3. Scroll down to 'document matches panel on right of the page
4. See error. "Levenshtein Matches"

Desktop (please complete the following information):

• OS: [e.g. iOS] macOS Mojave
• Browser [e.g. chrome, safari]. Both

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Is your feature request related to a problem? Please describe.
When I go to the Browse City (details) page, after selecting a city link from the Browse by City (no cache) page, I would like to see the name of the city on the page.

Describe the solution you'd like
I would like to see the name of the city on the page, possibly as so for example: "Browse by City - Adelaide."

Describe alternatives you've considered
I thought of nothing else. Open to suggestions.

Additional context
Link to sample page: https://dhil.lib.sfu.ca/wilde/city-details.html?city=Adelaide

Describe the bug
I just noticed that the number count is obscured in some of the boxes on this page, and perhaps others like it.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...' Reports
2. Click on '....' Sources
3. Scroll down to '....' First box under institutions, for example
4. See error

Expected behavior
I expect to see the number count on the page.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS] MacOS Mojave
• Browser [e.g. chrome, safari] Chrome
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Describe the bug
Some of the csv files on the data page are not downloading or are missing content. Those not downloading are the "Matching documents" and the "Matching paragraphs." I think the data fields also need to be updated, as match type is no longer relevant as everything is Levenshtein. The file missing content is the last one "Gephi paper matches."

To Reproduce
Steps to reproduce the behavior:

1. Go to 'Data (footer)
2. Click on 'Matching Documents link or Matching paragraphs link or the "Paper matches" link
3. See error "Cette page de fonctionne pas"

Expected behavior
When I select these links to files, I expect them to be able to open and download them.

Screenshots

Desktop (please complete the following information):

• OS: [e.g. iOS] MacOs Mojave 10.14.6
• Browser [e.g. chrome, safari]. Chrome

Is your feature request related to a problem? Please describe.
The height of items in the image gallery are inconsistent; the height of each row is always the maximum necessary for the longest item.

Describe the solution you'd like

I think the height of each item should match the longest, rather than having white space on the top and bottom. This is achievable by adding the following CSS (generated using FF Style Change inspector):

/* style.css | https://dhil.lib.sfu.ca/wilde/resources/css/style.css */

#content .row {
  display: flex;
  flex-wrap: wrap;
}

/* Inline #2 | https://dhil.lib.sfu.ca/wilde/gallery.html */

.col-xs-12.col-sm-4 {
  display: flex;
}

/* bootstrap.min.css | https://dhil.lib.sfu.ca/wilde/resources/lib/bootswatch/lumen/bootstrap.min.css */

.thumbnail {
  width: 100%; /*Necessary for making the items full width in small device mode*/
}

Additional context

Before:

After:

Describe the bug
There is an image missing from the Contributors page

To Reproduce
Steps to reproduce the behavior:

1. Go to '...' About
2. Click on '....' Contributors
3. See error

Expected behavior
I expect to see an image.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS] Mojave 10.14.6
• Browser [e.g. chrome, safari]. Chrome

The documentation page should have a table of contents to make it more navigable and to make it easier to link to particular sections of the document. Plus, most of the other pages (other than the Data page) have a column structure (col-4 and col-8, I think), so this will make the documentation a bit more consistent.

The table of contents will go on the left (and be sticky, I think) on desktop and at the top (and not sticky) on mobile. Not sure yet how it will be styled or structured since there may be various levels of nesting in the document.

Describe the bug
Some of the names of the databases on the Sources Page are showing up as urls rather than as names.

To Reproduce

1. Go to '...' About
2. Click on '....' Sources
3. Scroll down to '....' Databases
4. See error

Expected behavior
I would expect to see names rather than URLS.

Screenshots
See below

Desktop (please complete the following information):

• OS: [e.g. iOS] Mojave
• Browser [e.g. chrome, safari] Chrome
• Version [e.g. 22]

Is your feature request related to a problem? Please describe.
The PI needs a copy of the reports stripped of all XML tagging. This should be built into the java tools as part of the matching workflow.

Now that most of the pages use a table-based layout for listing out reports, we need to be able to make them usable on smaller screens. There are a few options:

1. We remove columns that we don't think are important (i.e. the various Counts). That would help a bit, but wouldn't totally solve the issue (but would be the easiest solution)
2. We add a container around all of the tables to make them horizontally scrollable. That's a fairly straightforward solution, especially since the tables themselves have a maximum number of rows, but it's still not the most usable since the horizontal scrolling isn't particularly obvious
3. We convert the table to a list of some sort once it hits a particular breakpoint. That can be only almost exclusively in CSS (so long as there are data-attributes that provide the column headings in the table) and is the most extensible option.

My vote is for 3, even though it's a bit trickier to get it right; that said, if we can get it done properly here, then there's a good payoff for the rest of the projects.

Is your feature request related to a problem? Please describe.
Instead of using page number pagination, can we do some sort of alphabetical pagination. Eg. in the big list of reports there are 20 page numbers, and if they're organized by newspaper title then page one is Australian Star, and page two is Australian Times, etc.

Describe the bug
Accents in the data sheets are showing up as symbols.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...' Footer, data page
2. Click on '....' Matching Documents link.
3. See errors on page

Expected behavior
I expect the accents to display up as accents.

Desktop (please complete the following information):
Mojave, Chrome

Is your feature request related to a problem? Please describe.
When I go to the Browse by Language (details) page, after selecting a language link from the Browse by Language (no cache) page, I would like to see the name of the language on the page.

Describe the solution you'd like
I would like to see the name of the language on the page, possibly as so for example: "Browse by Language - English."

Describe alternatives you've considered
I thought of nothing else. Open to suggestions.

Additional context
https://dhil.lib.sfu.ca/wilde/language-details.html?language=en

Describe the bug
Articles without headlines are not accessible via the browse by pages. The only way to access them is to use the previous and next buttons while reading a specific newspaper.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...' Browse by Region - Canada.
2. Click on '....' Try to click on the rows without headlines.
3. See error. It is not possible to access the individual report.

Expected behavior
I would expect to be able to access the individual report from the browse by pages. Perhaps some standardiased text ("No headline") could be generated for cases of articles with no headlines, from which a link to the report could be created?

Screenshots

Desktop (please complete the following information):
Mojave, Chrome

Right now, document.xql has a document:clip-string function, which trims the length of a string to a specific length and appends an ellipses if necessary. While that makes some sense if we're worried about bad headlines, it would be better to do this in CSS since it gives us greater control over how much of a headline is shown in different contexts, which we may need once #86 is resolved.

Describe the bug
Three images -- from The Paris Herald -- are not displaying the right title and are missing the description that goes with them. Is it because

To Reproduce
Steps to reproduce the behavior:

1. Go to 'Home Page'
2. Select 'About'
3. Select "Image Gallery"
4. Scroll down to Paris Herald Images

Expected behavior
I expect for the titles for these three images to look like the titles under the other images. There should also be descriptive text with these images.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS] Mac OSMojave 10.14.6
• Browser [e.g. chrome, safari]. Chrome & Safari
• Version [e.g. 22]

Describe the bug
A paragraph match % on the individual reports page is not the same as the same matching paragraph shown on the compare paragraphs page.

To Reproduce
Steps to reproduce the behavior:

1. https://dhil.lib.sfu.ca/wilde/view.html?f=tcea_3105
2. https://dhil.lib.sfu.ca/wilde/compare.html?a=tcea_3105&b=bnla_3296

You will see that the last paragraph shows that there is a 93.7% match with the Belfast News-Letter. When you click on the Compare Paragraphs page, however, the matching paragraphs are measured at 93.1%.

Expected behavior
I would expect the measure for the patching paragraphs would be the same across the different pages.

Screenshots
See links above.

Desktop (please complete the following information):
Mojave, Chrome.

Additional context
I spot checked other reports and comparison page, and found the same issue elsewhere.

Describe the bug
Including the cosine metric causes confusion in the UI. Drop it.

Describe the bug
https://dhil.lib.sfu.ca/wilde/list.html - page 4 and page 1 are the same.

The Newspapers list page should be tiled like the rest of the List pages. To make it a bit more useful, though, we should add a few more sorting options for sorting by:

• Region (default)
• Language
• Count

And while region and language should be grouped, count should be a flat list.

Is your feature request related to a problem? Please describe.
When I go to the Browse by Region (details) page, after selecting a region link from the Browse by Region (no cache) page, I would like to see the name of the region on the page.

Describe the solution you'd like
I would like to see the name of the region on the page, possibly as so for example: "Browse by Region - Algeria."

Describe alternatives you've considered
I thought of nothing else. Open to suggestions.

Additional context
https://dhil.lib.sfu.ca/wilde/region-details.html?region=Algeria

Describe the bug
All the symfony projects transitioned from bower to yarn in January. This one should transition as well.

Use content that Colette shared with us and modify the About page

A breadcrumb menu would provide another option for navigating through the site, making it easier for people to go from a single report to e.g. the "Browse Newspapers" page. It would also add a hierarchy to the site, which would again make things a bit easier for navigation and for clarifying things like the "Previous Report" and "Next Report" buttons.

Since the previous/next report buttons refer to Newspapers, I think we should use that as the main hierarchy:
i.e. for report asa_649, it would look something like:

Home / Newspapers / Australian Star / April 8, 1895

All other pages, I think, would just be flattened from the "Home" page, unless we want to reflect a different hierarchy:

Home / Data

Home / Image Gallery

Describe the bug
Left alignment on pages is not consistent across all pages.

The About, Browse, Search, Compare, and Network pages are standard pages, and all have the same left alignment of the page header with the text/image below the horizontal line (as well as above the horizontal line).

But the Data page, Contact page, License page, and Privacy Policy page, all do the left alignment of the page header and text differently than the pages above.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...' the bottom menu
2. Click on '....' any of the pages in the bottom menu

Expected behavior
I would expect the pages to have consistent left alignment.

Desktop (please complete the following information):

• OS: [e.g. iOS] Mojave 10.14.6
• Browser [e.g. chrome, safari] Chrome

Describe the bug
When you select the Read link on the Home Page under the "Love that Dare Not" heading, the user is taken to a page that says "cannot find" the article.

To Reproduce
Steps to reproduce the behavior:

1. Go to Home Page
2. Click on Read under the "Love that Dare Not" heading
3. See page that says "Cannot find"

Expected behavior
I expected to see a newspaper article after I selected the link on the Home Page.

Screenshots

Desktop (please complete the following information):

• OS: [e.g. iOS]. Mojave 10.14.6
• Browser [e.g. chrome, safari]. Chrome
• Version [e.g. 22]

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Newspaper titles sometimes begin with an article (such as "the in English, or Le in French) and sometimes don't. It is practice to maintain the article in the title when naming and citing them. Therefore I have tried to do so. But, this makes alphabetization an issue, as lots of papers get alphabetized, and therefore slower to find, by their article. A number of the Wilde site pages involve some kind of alphabetization of the newspaper titles, and so this is an issue that affects a number of pages.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Could we alphabetize the newspaper titles by the first name in the title following the article.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Not sure what alternatives there are.

Additional context
Add any other context or screenshots about the feature request here.

I have provided screenshots of sites in French and English that deal with this issue (in different ways).

Is your feature request related to a problem? Please describe.
I am worried users will not know what Levenshtein and Cosine is on the Compare page. We do not define what they are here, and nowhere else on the site do we now use Cosine. In fact, I think it would help to have brief explanations for all 4 items showing measures in the Compare tool [Word counts, Levenshtein, Cosine, and Difference].

Describe the solution you'd like
I am wondering if we can add hover text for all 4 elements which would provide brief definitions.

Describe alternatives you've considered
I haven't thought of anything else.

Create or refurbish (@ubermichael will dig out previous prototype) separate pages for reports. The different options should include "Browse by Date", "Browse by Newspaper", "Browse by Language", "Browse by City".

The new Newspaper page is slow to open (~more than 10 seconds), and remains an issue. The other pages added to reports display more quickly (though they can be slightly slow to display).

Is your feature request related to a problem? Please describe.
Each report should include a "Data updated on xxx" metadata tag. The data exports page also needs this feature.

The images in the image gallery don't flex intelligently; they maintain a 33% width, which makes the prose description of those images difficult to read. They should flex properly (going to 50% at around ~900px and at 100% by ~700ish pixels).

Is your feature request related to a problem? Please describe.
I think the All Reports page should be at the top of the list in the Reports drop down menu. It is the most important page. It would be ideal if it loaded faster than it does, but I added text at the top to let users know to wait a few seconds for the page to load.

Describe the solution you'd like
Can you please move up the All Reports page to the top of the list in the Reports drop down menu.

Describe alternatives you've considered
I have thought of no alternatives.

We have just received another draft of the documentation.

Is your feature request related to a problem? Please describe.
It is a request for clarification.

Describe the solution you'd like
On the All Reports page, can you please change one of the column names from "Words" to "Word count".

Describe alternatives you've considered
I haven't thought of anything else.

Describe the bug
The search system treats accented characters differently from unaccented characters.

To Reproduce
Steps to reproduce the behavior:

1. Go to https://dhil.lib.sfu.ca/wilde/search.html
2. Search for siecle
3. There are two results

Expected behavior
There should be about 30 results, as there are for searching for siècle.

Chronicling America: https://chroniclingamerica.loc.gov/about/api/

Trove: https://help.nla.gov.au/trove/building-with-trove/api

Gallica: http://api.bnf.fr/api-document-de-gallica

Describe the bug
“word lengths” should be changed to “word counts”

To Reproduce
Steps to reproduce the behavior:

1. Go to https://dhil.lib.sfu.ca/wilde/measure.html
2. See error

Describe the bug
"Levenshtein" does not need to be named on this Comparison page (documents).
It should be changed to read "Match: xx%"

Additionally the Match % text is a bit hard to differentiate from the text. Can a bit more spacing be added between it and the text. (I am open to other ideas too).

Additionally can all the text on the page be aligned left, like the Comparison paragraph page?

To Reproduce
Steps to reproduce the behavior:

1. Go to 'All Reports"
2. Click on a Link that has document matches
3. Scroll down to Document matches panel
4. Select Compare
5. You will see the Comparison page

Expected behavior
All we need to see is "Match: xx%" rather than "Levenshtein"

Screenshots
Here is a link to a sample page
https://dhil.lib.sfu.ca/wilde/compare-docs.html?a=lggj_1080&b=lcm_1642

Describe the bug
The inner pages for browse by city, date, language, etc. should be organized by date. They are unorganized at the moment.

To Reproduce
Visit any one of these pages

• By City
• By Language
• By Newspaper - might already be sorted
• By Region

Expected behavior
The report lists should be sorted by date.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to https://github.com/sfu-dhil/wilde/list.html
2. Check that the Evening News report for April 4 with 145 words has one document-level match.
3. Click on the date to open that report.
4. Scroll down to Document Level Matches
5. See that there are not document level matches reported.

Expected behavior
Either there should be a document-level match there or the reports list should show that there are no matches.

Acknowledgements
First reported by @KimberlyODonnell.

Currently, the report lists are simple unordered lists with a link and a count. This isn't particularly usable, since it's hard to find individual items at a glance; it should be redesigned to make better use of the available space and to make it easier to go to reports.

Describe the bug
The graph on the reports page doesn't show the lines, only the legend.

To Reproduce
Steps to reproduce the behavior:

1. Go to the reports page
2. Wait for the graph to load
3. The lines never load

Expected behavior
The graph should show the lines.

Screenshots
(Firefox on left; Chrome on right)

The error from the console is:

TypeError: d.values[lastHoveredBarIndex] is undefined d3.stacked.bar.js:458:38
    tooltipContent https://dhil.lib.sfu.ca/wilde/resources/js/d3.stacked.bar.js:458
    each https://dhil.lib.sfu.ca/wilde/resources/lib/d3/d3.min.js:3
    Y https://dhil.lib.sfu.ca/wilde/resources/lib/d3/d3.min.js:1
    each https://dhil.lib.sfu.ca/wilde/resources/lib/d3/d3.min.js:3
    tooltipContent https://dhil.lib.sfu.ca/wilde/resources/js/d3.stacked.bar.js:457
    showTooltip https://dhil.lib.sfu.ca/wilde/resources/js/d3.stacked.bar.js:444
    $/< https://dhil.lib.sfu.ca/wilde/resources/lib/d3/d3.min.js:1

Desktop (please complete the following information):
FF 74; Chrome 80.0.3987.163 on Mojave 10.14.6.

Additional context

If page load is a concern, I think all of the Javascript on the page should be removed, including the filtering features on the page to make the page as simple as possible. It will still take time to render and load, but it should cut it down.

This is a request for information about the data in my database.

I am requesting updated counts for: number of news articles and the total word count for these articles.

I will update my Overview page with this info.

Add the new images found on Vault (https://docs.google.com/document/d/1EvEXKwdSjGsLKb_SHcDwUQgaemwCIFBLNz67UqnwQWc/edit?usp=sharing) to the gallery.