sgrottel / everythingsearchclient Goto Github PK

The Query Results are received via IPC to a MessageOnly Window, and a Thread handling timeout behavior. Those are always created and destroyed for every Query. Especially when using paged-queries of a large number of files, those should be reused.

• Introduce a heuristic when to reuse the window & message/wait thread.
• Refactor code to more easily manage window & message/wait thread.
• Reuse window & message/wait thread for consecutive queries.

Closing the application must not be blocked or significantly slowed down.

Built-in filter macros, like video: are currently not supported.

Using Everything's debug mode (https://www.voidtools.com/forum/viewtopic.php?t=1713) it can be seen, that the filter macros are replaced by a collection of file extensions.

Provide convenience string constants for those collections as part of the SearchClient interface.

On some, slow CI VMs this test fails.
Timeout?

• https://github.com/sgrottel/EverythingSearchClient/actions/runs/3713196098/attempts/1
• https://github.com/sgrottel/EverythingSearchClient/actions/runs/3713196098/jobs/6295569787

D:\a\EverythingSearchClient\EverythingSearchClient\TestProject\bin\Release\net6.0-windows\TestProject.dll
  Failed TestMethodWaitOrErrorWhenBusy [7 m 22 s]
  Error Message:
   Test method EverythingSearchClient.TestProject.TestBusyBehavior.TestMethodWaitOrErrorWhenBusy threw exception: 
System.Exception: Everything service is busy
  Stack Trace:
      at EverythingSearchClient.SearchClient.Search(String query, SearchFlags flags, UInt32 maxResults, UInt32 offset, BehaviorWhenBusy whenBusy, UInt32 timeoutMs) in D:\a\EverythingSearchClient\EverythingSearchClient\EverythingSearchClient\SearchClient.cs:line 139
   at EverythingSearchClient.SearchClient.Search(String query, BehaviorWhenBusy whenBusy, UInt32 timeoutMs) in D:\a\EverythingSearchClient\EverythingSearchClient\EverythingSearchClient\SearchClient.cs:line 247
   at EverythingSearchClient.TestProject.TestBusyBehavior.TestMethodWaitOrErrorWhenBusy() in D:\a\EverythingSearchClient\EverythingSearchClient\TestProject\TestBusyBehavior.cs:line 64

This might require to upgrade IPC to V2

Previous Issues (#19) showed that sometimes answers are not received. Investigate and try to fix or mitigate.

I think in most cases, nuget and many package authors choose P / Invoke and dll because they don 't want to carry exe installer or use IPC. Can I implement / support a fully managed version of everything ?

like this code

https://github.com/BookerLiu/GeekDesk/blob/7d3f1c9af056d3354e273c18faa1f509ea2bedea/Plugins/EveryThing/EveryThingUtil.cs#L28

Run ExampleApp.exe with elevated user rights (as Admin), and then SearchClient.Search seems to not return.

Observed on:

• e263020
• b6d4572 (tag v0.6)

Some features are only available via search api Query 2.
The fallback is nice, most of the time not needed, and it should be able to opt-out of it.

Rational: when querying paged results, it does make sense to request them in a sorted order.

The main core classes of the project work on the Windows-Platform only, because of specific P/Invoke, anyway. While the original idea was to keep the interfaces platform-independent, and to later add alternative implementations for other platforms, this is not going to happen anytime soon. So, let's make this a bit cleaner and make the whole package target Windows OS only, for now.

While the project already does this correctly, the nuget package does not.

search.Search("empty:");

Triggers in MessageReceiverWindow::ParseResultDataVersion2() an exception at:

createDate = DateTime.FromFileTime(timecode);

because timecode is -1

Tests on Github Actions currently disabled, because Everything service can no longer be used.

Find a light-weight configuration for Everything or a strong VM to run CT on.

In one of my application I do paged-queries like this:

result = everything.Search(query, QueryPageSize, offset, timeoutMs: QueryTimeoutMs);

QueryTimeoutMs is set to 10000.
Sometimes this call does not return ... ever.

I have seen such behavior in the context of debugging with break points.
The IPC answer message likely "got lost".
The timeout mechanism is meant to provide an exit path in this case.
This is likely what's happening here.

Not sure if it's worth it...