shadowfen / jshu Goto Github PK

Dear Shadowfen,

when testing jshu on my Ubuntu16.1LTS system, I figured some issues:

1. When path to the script contains spaces, then no test-results are produced. This is due to missing quotes in the "$test_file" variable in jshuFinalize() (here a diff of jshutest.inc):

- echo "\<testsuite failures ... "${total}\">" >${test_file}
- cat $jshu_content_file >>$test_file
- echo "\</testsuite>" >>$test_file
+ echo "\<testsuite failures ... "${total}\">" >"${test_file}"
+ cat $jshu_content_file >>"$test_file"
+ echo "</testsuite>" >>"$test_file"

2. Also in function jshuRunTests():215, spaces in the path are not interpreted correctly by the command cd ${_jshu_run_curdir}

quotes fixed this issue (see diff):
- cd ${_jshu_run_curdir}
+ cd "${_jshu_run_curdir}"

3. A Segmentation-Fault is caused when executing the incrbuild_unitTest.sh. This is most likely due to the function parseVersion(). This function is supposed to call function in parseVersion() from sourced script increment_build.sh. However it ends up in an "infinite" recursion. Renaming incrbuild_unitTest.sh::parseVersion() to incrbuild_unitTest.sh::parseVersion_Test() solved the issue. If so, then also update content of jshuTestFunctions="parseVersion getBldFileName_noParam" to jshuTestFunctions="parseVersion_Test getBldFileName_noParam"

regards ireicht