shakyshane / svg-sprite-data Goto Github PK

The raw property defined in lib/svg-sprite.js/SVGSprite.prototype._addToSprite and used in the default 'symbols' template in gulp-svg-sprites is broken.

Current code:

var children = svgInfo.svg.root().childNodes();
// console.log('children', children);

var raw = children.join("");

// Register the single SVG with the sprite
var data = svgInfo.toSVG(true);

The children are objects representing XML element nodes. They can’t be converted back to XML syntax with just a string join. Result will be '[object Object][object Object][object Object]' for an array of three "nodes", for instance.

Instead, this code works:

var raw = svgInfo.svg.root().childNodes().reduce(function(prev, child) {
    var xml = svgInfo.svg.toXMLString(child);
    return prev + (typeof xml === 'string' ? xml : '');
}, '');

// Register the single SVG with the sprite
var data = svgInfo.toSVG(true);

Note that the svgInfo.toSVG call that follows will do the exact same work again (it converts the parent <svg> element to a string, and will call toXMLString on its children), which is wasteful. There might be a better way.

hey @shakyShane gulp-svg-sprites uses this module as a dependency could you please also add me to this repo? thx.

@shakyShane npm publish please