sharathpuranik / libbmp Goto Github PK

added function: rgb_pixel_t *bmp_get_color(bmpfile_t *bmp, int c)
addued function: bool bmp_set_pixel(bmpfile_t *bmp, uint32_t x, uint32_t y, 
rgb_pixel_t pixel)

What steps will reproduce the problem?
1. use 720x480 rgb565 as source
2. set depth as 16

If I set the depth to 32 I get the image I expected, but at twice the size. If 
I set the depth to 16 I get a skewed image.

See the example here:
http://github.com/coolaj86/rgb565-tools/blob/master/src/rgb565tobmp.c

Fixes the skewing 16-bit BMPs.

bmp_create_from_file() is unimplemented, still marked as TODO in bmpfile.h.

Here is a new version for reading bmp

maybe you can apply it?!

What steps will reproduce the problem?
1. Opening the produced bmp file in GIMP v2.8.4

What is the expected output? What do you see instead?
It works actually, in mspaint, default picture viewer, no problem.
Except that GIMP v2.8.4 says that it's invalid..

What version of the product are you using? On what operating system?
Libbmp v0.1.3 | Windows 7 x64 Home Premium with MinGW GCC v4.7.2

Please provide any additional information below.
could this be a simple minor bug in the bmp header?

By the way, I like this library. :)

Correct me if I'm wrong, but the description claims that this library can read 
bitmaps, yet there's no corresponding bmp_read function (that reads from a 
file). So unless you're creating bitmaps by hand or procedurally, how is this 
library useful? I can't just read in a .bmp file and get the RGBA info I need 
to make a texture.

added function: rgb_pixel_t *bmp_get_color(bmpfile_t *bmp, int c)
added function bool bmp_set_color(bmpfile_t *bmp, int c, rgb_pixel_t pixel)