Sharezone is a collaborative school organization app for iOS, Android, macOS and web with +450,000 downloads. Built with Flutter & Firebase.
Home Page: https://sharezone.net
License: European Union Public License 1.2
![dependabot[bot] avatar](https://avatars.githubusercontent.com/in/29110?v=4 "dependabot[bot]")
E.g. the lint package.
When going to the Settings > "about us" ("Über uns") page the app version can't be loaded.
Instead of loading the version is says "loading version..." forever.
The version should be displayed.
Possibly related to the package_info_plus (no implementation for macOS for the old version we use)
Use newer version of package_info_plus
To test and try out a PR, we should create and deploy a separate Firebase Hosting App for every PR. There is also a tutorial in the Firebase Docs, how you can do it: https://firebase.google.com/docs/hosting/github-integration?hl=en
When a new comment is written on a homework a push notification is sent out to other users of that homework.
Tapping on the notification doesn't open the homework where a new comment was added.
The same issue might also happen with comments on information sheets - I haven't tested it yet.
A dialog showing the content of the push notification is displayed.
The homework page with the new comment should be opened.
Pixel 4a, Android 12, Version 1.6.1 (315)
Make sure that Google location is correct
Add RevenueCat
Add Stripe
Add email sending service
Send email to users that have an email about privacy policy changes (and TOS and Plus)
Move existing tickets from https://gitlab.com/codingbrain/sharezone/sharezone-app to this repository.
If we use discussions (see #29) we should copy them to the right place directly.
When using tab to change the focus of the active element on the login page the "Sign in with Apple" is skipped.
The tab focus skips the "Sign in with Apple" button.
The tab focus should focus the "Sign in with Apple" button after focusing the blue login button.
Original issue: https://gitlab.com/codingbrain/sharezone/sharezone-app/-/issues/1396
When opening the changelog page on macOS there is an infinite loading spinner.
There is a loading spinner. The changelog is not displayed.
The changelog will be displayed.
Possibly related to the package_info_plus (no implementation for macOS for the old version we use)
Original issue: https://gitlab.com/codingbrain/sharezone/sharezone-app/-/issues/1416
Use newer version of package_info_plus
Currently a user can only add an exam manually via a start and end time.
Just like with the lessons there should be the option to chosse a lesson slot/time:
Open questions:
If we open-source our software we need to make sure that we don't use a package that is licensed under a strong copy-left license (e.g. GPLv3) that would force us (if I understood it correctly) to also make our project licensed under the same license (e.g. we would need to use GPLv3).
This could be done with something like dart_license_checker or FOSSA.
When previewing a PDF inside Sharezone and clicking onto a link inside the document it should open the link inside e.g. a web browser.
Nothing happens
The URL of hyperlink should be opened inside a browser / new tab / whatever.
This also expands to e.g. mailto URIs (do not work aswell).
This seems to be an issue with the native_pdf_view plugin we use.
See: ScerIO/packages.flutter#82
It sometimes happens that the to be done until date could not load. In this case, is the date field empty. However, the does not show an error message, if you try to save this homework without a date. As a result, the homework can not be displayed and is forever invisible.
Should be run for all PRs
See #24
Some ideas:
Make the creation of homework automatically select the subject from the plan that is ongoing at that moment.
main to protected.We've decided that (at least initially) we will require a signed CLA for new contributions.
We might use a CLA that is based on the harmony project (http://harmonyagreements.org/agreements.html).
This is also used by e.g. Threema.
Also see https://joinup.ec.europa.eu/collection/eupl/news/oss-licence-and-contributor for the differences for the changed version for the EU and the standard harmony licence.
Building our app for any platform with Flutter > 2.5.x will show this warning:
The plugin `barcode_scan` uses a deprecated version of the Android embedding.
To avoid unexpected runtime failures, or future build failures, try to see if this plugin supports the Android V2 embedding. Otherwise, consider removing it since a future release of Flutter will remove these deprecated APIs.
If you are plugin author, take a look at the docs for migrating the plugin to the V2 embedding: https://flutter.dev/go/android-plugin-migration.
Unfortunately, the barcode_scan package is not maintained anymore:
Source: https://github.com/mintware-de/flutter_barcode_reader
Therefore, we need to replace the barcode_scan package to fix this warning.
On the web app, it's not possible to upload a file anymore. This effects the "Files", "Homework" (attachments) and the "Blackboard" (attachments) feature.
After picking from the browser file picker, nothing happens.
After picking a file, the app should upload the file.
Many customers already confirmed this issue, when contacting the support.
We had once the idea to introduce a class licence which you buy and enables more feature for a class inside Sharezone.
We don't persue this idea anymore (at least not in the near future) so the code can be removed. It is hidden behind a feature flag anyway.
Example:
A Homework that is due on the 1st november is shown in the"later" category instead in the "tomorrow" category if the current date is the 31st october.
TODO: Haven't reproduced myself yet.
Homework is in "later" category
Homework is in "tomorrow" category
See user report in Discord: link
Original issue: https://gitlab.com/codingbrain/sharezone/sharezone-app/-/issues/1193
Unknown (user report)
In our Dart code we follow the convention of leaving spaces after the slahes of comments.
A comment with bad spacing is a comment that has no space after the slashes.
Good comment: // foo bar
Bad comment: //foo bar
We have a
sz fix-comment-spacing command which fixes the bad comments by inserting spaces after slashesWhen checking for / fixing comments with bad spacing there are false-positives as these bad comments are found via RegEx.
The current implementation in fix_comment_spacing_command.dart(link to old commit - might be updated already) uses a simple regex to find comments via their slashes:
/// Matches "//" and "///"
final _commentSlashesRegex = RegExp(r'\/{2,3}');and then uses some simple heuristics to try and filter out stuff like urls etc.
If there are edge cases one can use add the following comment to a file: // ignore_for_file: no_spaces_after_comment_slashes which is a workaround for this issue.
print('//should not get matched as this is not a real comment');sz fix-comment-spacingThe analyze step fails as the statement above is falsely interpreted as a comment with bad spacing.
The sz fix-comment-spacing wrongly "fixes" the statement above by inserting a space behind the print statement.
The analyze step should not fail.
The sz fix-comment-spacing should not wrongly fix the statement.
// An empty comment with no spaces after is okay:
//
//
void main() {
print('//the example from above');
}
// What about this:
///////////heey
// //Is this alright?
// An empty comment at the end of the file is probably also okay:
///
// https://www.this-has-slashes-in-url.comSee also the already existing test cases (link to old commit - might be already updated)
Old Issue from GitLab: https://gitlab.com/codingbrain/sharezone/sharezone-app/-/issues/1455
The Dart code should not be checked by regex as in this case there will always be edge cases for which it's not simple to find out if it's a real comment or just something that looks like a comment inside a string.
A better solution would be to analyze the Dart code via its AST.
One could possibly create an analyzer plugin or create a new lint rule for the official Dart linter.
The last option should probably be preferred as it seems like less work and it will benefit all other users.
I opened a ticket in the dart-lang/linter repo: "New lint for leaving space between comment slashes (//) and content."
Some random notes:
We should remove Telegram and WhatsApp from our support page, because we don't offer these option anymore.
When a SnackBaris displayed in Sharezone in dark mode the text can't be read (see Screenshot below).
The text color seems to be black instead of white.
The problem seems to appear on all SnackBars the above is just one example.
The SnackBar text is black on black and thus not legible.
The text should be white or some other color that is legible on the dark background.
SnackBar in dark mode:
In light mode the text is legible:
Device: Web
App version:
Newest version, e.g. at commit bce3a2f. I tried reproducing on 1.6.1 (315) version on my phone (which is way older than the mentioned commit) but it seems to work there. The issue might be related to #51.
https://pub.dev/packages/cross_file (official flutter package)
The Material Icons are looking weird / wrong on alpha web app.
See Android / iOS app (I'm now too lazy to make the screenshots in the android / ios app 😅)
See broken behavior
95.0.4638.69Currently, all events are loaded. However, we show to the user only the events for today and the future. To safe Firebase usage, we shouldn't load the past events anymore.
When trying to submit a feedback a SnackBar with a generic error message appears.
A generic error SnackBar appears. The feedback is not submitted.
The feedback should be submitted / sent to our backend.
Possibly related to the package_info_plus (no implementation for macOS for the old version we use)
Original issue: https://gitlab.com/codingbrain/sharezone/sharezone-app/-/issues/1416
Use newer version of package_info_plus
With implicit-casts: true (current setting) it's easy to get runtime errors that could be caught statically.
When disabling the option there needs to be some changes in the code to accommodate.
Should we e.g. put bug reports into issues and feature requests into discussions?
Can you create a shortcut from the issue creation dialog into the discussions? ("Create issue" --> "Feature Request" --> Forwarded to discussions tab)
What templates should we have in "issues"?
What other things than feature requests and bug reports do we have that might go into issues or discussions?
I don't how, but the user 5VLQnu7xwSNfVjIiyXk6JRef22N2 has a broken user document. Fields like typeOfUser are missing. Therefore, this user can not see any homeworks, because the cloud function, which assigns the users to homework, do not have the typeOfUser.
The default of Dart/Flutter projects is a line length of 80 chars which we find limiting.
When editing a homework and pressing "save" the resulting SnackBar doesn't disappear (see screen capture below).
The SnackBar that appears stays on the screen forever.
The SnackBar should disappear after a few seconds or after the changes have been received/confirmed by the backend.
E.g. from login_page.dart:
// Autofill sollte im Web mit der Kombination eines StreamBuilders /
// FutureBuilders nicht verwendet werden, weil es ansonsten zu
// Problemen mit den TextFeldern kommt, wenn ein Error-Text angezeigt
// wird.
//
// Ticket: https://github.com/flutter/flutter/issues/63596
//
// Sobald dieser Bug behoben ist, kann Autofill fürs Web wieder
// verwendet werden.
autofillHints: [if (!PlatformCheck.isWeb) AutofillHints.email],The bug is now fixed and thus autofill can be reenabled.
There are several files with Autofill deactivated on the web, those can be found by doing a text search of parts of the comment above.
See https://github.com/SharezoneApp/github-labels (private) for some ideas from @nilsreichardt
Random notes:
page:settings/profile)When selecting the "contact support" option on the change account type dialog on Android the email program does not open (should open with predefined text).
Nothing happens on Android
The email program should open with a predefined email template.
I/UrlLauncher(16600): component name for mailto:[email protected]?subject=Typ+des+Accounts+%C3%A4ndern+%5BJZ4jMkAgetSwMafFDEWBGr4IYuB2%5D is {com.google.android.gm/com.google.android.gm.ComposeActivityGmailExternal}
E/MethodChannel#plugins.flutter.io/url_launcher(16600): Failed to handle method call
E/MethodChannel#plugins.flutter.io/url_launcher(16600): java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference
E/MethodChannel#plugins.flutter.io/url_launcher(16600): at io.flutter.plugins.urllauncher.MethodCallHandlerImpl.onLaunch(MethodCallHandlerImpl.java:88)
E/MethodChannel#plugins.flutter.io/url_launcher(16600): at io.flutter.plugins.urllauncher.MethodCallHandlerImpl.onMethodCall(MethodCallHandlerImpl.java:40)
E/MethodChannel#plugins.flutter.io/url_launcher(16600): at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:233)
E/MethodChannel#plugins.flutter.io/url_launcher(16600): at io.flutter.embedding.engine.dart.DartMessenger.handleMessageFromDart(DartMessenger.java:84)
E/MethodChannel#plugins.flutter.io/url_launcher(16600): at io.flutter.embedding.engine.FlutterJNI.handlePlatformMessage(FlutterJNI.java:865)
E/MethodChannel#plugins.flutter.io/url_launcher(16600): at android.os.MessageQueue.nativePollOnce(Native Method)
E/MethodChannel#plugins.flutter.io/url_launcher(16600): at android.os.MessageQueue.next(MessageQueue.java:335)
E/MethodChannel#plugins.flutter.io/url_launcher(16600): at android.os.Looper.loop(Looper.java:183)
E/MethodChannel#plugins.flutter.io/url_launcher(16600): at android.app.ActivityThread.main(ActivityThread.java:7656)
E/MethodChannel#plugins.flutter.io/url_launcher(16600): at java.lang.reflect.Method.invoke(Native Method)
E/MethodChannel#plugins.flutter.io/url_launcher(16600): at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
E/MethodChannel#plugins.flutter.io/url_launcher(16600): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
E/flutter (16600): [ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: PlatformException(error, Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference, null, java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference
E/flutter (16600): at io.flutter.plugins.urllauncher.MethodCallHandlerImpl.onLaunch(MethodCallHandlerImpl.java:88)
E/flutter (16600): at io.flutter.plugins.urllauncher.MethodCallHandlerImpl.onMethodCall(MethodCallHandlerImpl.java:40)
E/flutter (16600): at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:233)
E/flutter (16600): at io.flutter.embedding.engine.dart.DartMessenger.handleMessageFromDart(DartMessenger.java:84)
E/flutter (16600): at io.flutter.embedding.engine.FlutterJNI.handlePlatformMessage(FlutterJNI.java:865)
E/flutter (16600): at android.os.MessageQueue.nativePollOnce(Native Method)
E/flutter (16600): at android.os.MessageQueue.next(MessageQueue.java:335)
E/flutter (16600): at android.os.Looper.loop(Looper.java:183)
E/flutter (16600): at android.app.ActivityThread.main(ActivityThread.java:7656)
E/flutter (16600): at java.lang.reflect.Method.invoke(Native Method)
E/flutter (16600): at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
E/flutter (16600): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
E/flutter (16600): )
E/flutter (16600): #0 StandardMethodCodec.decodeEnvelope
package:flutter/…/services/message_codecs.dart:607
E/flutter (16600): #1 MethodChannel._invokeMethod
package:flutter/…/services/platform_channel.dart:156
E/flutter (16600): <asynchronous suspension>
E/flutter (16600): #2 launch
package:url_launcher/url_launcher.dart:101
E/flutter (16600): <asynchronous suspension>
E/flutter (16600):
At https://alpha.web.sharezone.net we host an automatically deployed version from the main branch.
We should make clear that we do not make any guarantee about anything in this version.
There may be features not included by our privacy policy or tos and that there might be bugs that may lead to data loss. I guess for new features there might be even security risks (there might be ways to access data from other users if it haven't been secured properly) although I'm not sure how far we can go in this regard. I guess we still need to make some guarantees about security of ones data.
Currently, we write on our support page "In der Regel antworten wir von Mo. - So. innerhalb von wenigen Stunden". This isn't true anymore.
Instead, we should write something like: "Bitte beachte, dass es ein bis zwei Wochen dauern kann, bis wir antworten (in Einzelfällen auch länger)."
Currently in E2E tests (Flutter driver or in the future integration_test) we currently hard-code the login credentials. These should be removed and changed if we open source our repo.
They have to be changed as they can still be seen in the commit history.
The problem is that we are using a version of sign_in_with_apple, which is does not support iOS 15 (see more details in aboutyou/dart_packages#213).
To fix this, we need to upgrade sign_in_with_apple to ^3.1.0 or higher.
The add homework and infosheet page is effected from this ui bug.
Google Pixel 4a
If a user tries to create an account with or change an existing username to a username with an invalid character (e.g. "!", "_") and tries to save / confirm that name then a SnackBar appears that says "Please choose a name with more than one character" which does not make sense.
A SnackBar is shown that says "Please choose a name with more than one character".
Either:
Original issue: https://gitlab.com/codingbrain/sharezone/sharezone-app/-/issues/1454
See:
4.7 You need to refer to the licence inside the source code.
The choice of the licence must be stated where the software is provided (e.g. on the software's website). There is no need to include the actual text of the licence there, a name and a link to the original licence text will better ensure the reference to a single source. This informs the public what licence the software will be released under, but it's not sufficient for legal purposes. For that, the software code itself must refer to the licence or contain the licence. The standard way to do this is to put the full licence text in a file called “COPYING” (or “LICENCE”), and then put a short notice at the top of each source file, naming the copyright, date, holder and licence, and informing the reader where to find the full text of the licence. An example of “short notice” for software distributed under the EUPL is the following:
/* * Copyright 2007 YOUR-ORGANISATION4 * * Licensed under the EUPL, Version 1.1 or – as soon they will be approved by the European Commission - subsequent versions of the EUPL (the "Licence"); * You may not use this work except in compliance with the Licence. * You may obtain a copy of the Licence at: * * https://joinup.ec.europa.eu/software/page/eupl5 * * Unless required by applicable law or agreed to in writing, software distributed under the Licence is distributed on an "AS IS" basis, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the Licence for the specific language governing permissions and limitations under the Licence. */In the above example, the original author accepts later versions of the EUPL, which could be published by
the European Commission. Distributing “under the EUPL” without any indication of a version number
would produce the same effect, however less explicitly.
Note: The link https://joinup.ec.europa.eu/software/page/eupl5 seems to be outdated. Should be replaced.
When selecting the "contact support" option on the change account type dialog the template text has "+" where spaces should be on some platforms.
The text contains "+" where spaces should be.
The text should not have these special characters instead of spaces etc.
This does NOT happen with the web app when having gmail inside the browser as the default mail handler.
UrlLauncherExtended seems to encode the template text as an URL which causes spaces to be changed to "+".
Original issue: https://gitlab.com/codingbrain/sharezone/sharezone-app/-/issues/1404
A homework with a submission that was sucessfully submitted, then marked as "not done" and then marked as done again can't be marked as done again.
(See video below)
Original Issue: https://gitlab.com/codingbrain/sharezone/sharezone-app/-/issues/1426
Signing in via the web app is possible:
Error is thrown
Sign in should be possible
I received already some user reports that they are also able to sign in the web app.
We might add this so unknown people can't use up all our CI resources. Might be especially helpful if add automated E2E tests.
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
Django
The Web framework for perfectionists with deadlines.
Laravel
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft
Open source projects and samples from Microsoft.
Google
Google ❤️ Open Source for everyone.
Alibaba
Alibaba Open Source for everyone
D3
Data-Driven Documents codes.
Tencent
China tencent open source team.