you can see my website. I can make it look something like this.

I want to add a preloader to this website. can you assign me this issue?

Description

When a databsae conncetion is made, the connection is not closed after its use. Further, that close call must be made in a finally block otherwise an exception could keep the call from being made.

Expected behavior

A final clause after the try-catch to close the database connection

Actual behavior

No final clause to close the database conneciton

Possible fix

Add a final clause to close the connection

Steps to reproduce

Selecting a book which calls the getBookById() method call that then creates a database connection

Context

Exception was thrown when querying book.

Additional information

No response

hello
I tried to run the project on my laptop in the same way as your procedure in the readme file.
The java, tomcat, MySQL connections are smooth and stable but whenever I try to run the project,
Firstly it will show the home page correctly.
But when I try to do admin login or user login or see available books, it gives me errors like
" HTTP STATUS 404 - The origin server did not find a current representation for the target resource or is not willing to disclose that one exists."
Is there any update to the content or any other thing, I tried general solutions available on the Net, but nothing worked.
Can you please tell me the solution?

@shashirajraja #

Hey i found your project interesting and wanna contribute to the ui of the available books page if no one is working on it.

Description

In ProcessPaymentServlet.java at line 48, there is the possibility of hitting a null pointer reference. Line 46 has a condition to check != null how ever that condition does not cover the for loop of the cartItem list. The If condition (line 46) needs to cover the entire for loop starting at line 48.

Expected behavior

list does not hit null reference when iterating the loop at checkout

Actual behavior

list hits null reference and an error is thrown.

Possible fix

The If condition (line 46) needs to cover the entire for loop starting at line 48.

Steps to reproduce

In ProcessPaymentServlet.java at line 48, there is the possibility of hitting a null pointer reference. Line 46 has a condition to check != null how ever that condition does not cover the for loop of the cartItem list. The If condition (line 46) needs to cover the entire for loop starting at line 48.

Context

Was doing code review and running find bugs on the code

Additional information

No response

@shashirajraja

Since nowadays servlets are being used very less at the industry level. But I appreciate your effort in creating the project.

I have created a REST API application for your online store application. Used HIbernate instead of JDBC behind the scene.
Refer - Book Store App

I hope it will be great learning for you.

After buying certain amount of books the quantity of books available is not getting decreased

Hey there!

I belong to an open source security research community, and a member (@S54r) has found an issue, but doesn’t know the best way to disclose it.

If not a hassle, might you kindly add a SECURITY.md file with an email, or another contact method? GitHub recommends this best practice to ensure security issues are responsibly disclosed, and it would serve as a simple instruction for security researchers in the future.

Thank you for your consideration, and I look forward to hearing from you!

(cc @huntr-helper)

I would like to add a relevant and suitable icon for the website. Kindly assign this task to me.

Currently the database details configurations is hardcoded in DatabaseConfig.java file, but we need to read it from some properties file and use
Like config.properties file, which should contains all the db properties like dbName, dbHost, etc.

could you assign me this issue so that i can make them look good .it will require a few lines of code .
please assign me this under hactoberfest

Detailed description

Header is very important part of website soo a can make the header for the website and that will match the design of the website

Context

Header is very important part of website without header website is incomplete.
header will make the website better.

Possible implementation

No response

Additional information

you can see my website website

Detailed description

Improve the UI and make some transitions and animations in the website

• Add more readability to the webpages
• Simplify the structure of interlinked webpages

Context

to Improve the readabilty of the content and enhancement of the user experience or user time on the website

Possible implementation

No response

Additional information

No response

Hi shashirajraja,

I hope this message finds you well. During my review of your codebase, I noticed the presence of dead code in the User class, particularly in the method retrieveFromHttpServletRequest, where significant portions of code are commented out and not actively used.

Why Refactor?

Code Cleanup: Removing dead code contributes to a cleaner and more maintainable codebase.
Reduced Complexity: Deleting unused code reduces the overall complexity of the project, making it easier for developers to understand and navigate.
Refactoring Proposal:

package com.bittercode.model;

import java.io.Serializable;
import java.util.List;

public class User implements Serializable {

    private String emailId;
    private String password;
    private String firstName;
    private String lastName;
    private Long phone;
    private String address;
    private List<UserRole> roles;

    // Existing getter and setter methods

    // Dead code removal
    // public static User retrieveFromHttpServletRequest(HttpServletRequest req) {
    //     // ... (previously commented out code)
    // }
}

I recommend deleting the commented-out code within the retrieveFromHttpServletRequest method, as it is currently not actively used and might lead to confusion for developers maintaining the codebase.

Additionally, please consider performing a broader sweep across your project to identify and delete any other unneeded files or dead code segments. Keeping the codebase free of unused artifacts enhances its clarity and maintainability.

Feel free to incorporate this suggestion, and if you have any questions or need further assistance, please don't hesitate to reach out.

these text boxes should be aligned properly

could you assign me this under hactoberfest

It show the incorrect password or username as Admin in Admin log in
Same issue in user log in.

Description

we have'nt created the null values restriction for the fields , like if we dont enter the password or dont enter the all fields still its shows the registration successfully. We should have the pattern matching for the email as well as phone number.

Expected behavior

instead of redirecting page to regitration successfully for null values, it should thrown an error and show it in next page

Actual behavior

it is accepting null values ,

Possible fix

we should add the not null in database field and as well as in the html code we should place placeholder and pattern matching for the input fields.

Steps to reproduce

create table if not exists users(username varchar(100) primary key,password varchar(100) not null, firstname varchar(100) not null,
lastname varchar(100),address text not null, phone varchar(100 ) not null,mailid varchar(100) unique,usertype int) ;
2.
RequestDispatcher rd = req.getRequestDispatcher("userreg");
rd.include(req, res);
pw.println("Sorry for interruption! Register again");
// redirection to empty page

Context

when i tried to put null values its shows the ambigous result.

Additional information

No response

i want to solve it.

Hey! I would like to help update the README.md file as most of the content seems to be repetitive. Kindly assign it to me.

I want to add more books to the list as it is a library.
Can I make this contribution under hacktoberfest'22?

Detailed description

Have raised a Pull Request add a return book feature for the customers.
#136

Context

This can be used for returning the books that are damaged or aren't usable.

Possible implementation

No response

Additional information

No response

this button should be styled accordingly with the website

kindly assign me this under hactoberfest

Detailed description

I can add beautiful hover effect in your website header and in all buttons which will match the design of your website.
please @shashirajraja assign this issue to me.

Context

With hover effect website looks more attractive

Possible implementation

No response

Additional information

No response

its showing us this error:
TYPE: EXCEPTION REPORT
MESSAGE: ERROR INSTALLING SERVLET CLASS
DESCRIPTION:THE SERVER ENCOUNTERED AN UNEXPECTED CONFITION THAT PREVENTED IT FROM FULFILLING THE REQUEST
error instantiating servlet class

Reason/Context

Why we need this improvement?
In this current version of the page, there is no labels or placeholders in the input section.

How will this change help?
It will enhance the UI of the webpage. It will ensure users to type into the input section of the page by just clicking on the labels provided. Hence giving a better user-experience.

Description

What changes have to be introduced?
Few changes needs to be done where placeholders and labels are to be added.

Will this be a breaking change?
No, it will just make the heading quote animated.

How could it be implemented/designed?
This can be achieved by adding adding labels and placeholder text in each of the inputs,
i.e, by writing few lines of codes in all the html files containing input tags.

Want to Work on this under Hacktoberfest2022. Please assign me. @shashirajraja

Description

Hey,
Please assign this issue so I can make the home screen buttons more awesome.

Expected behavior

The buttons will get more attractive

Actual behavior

Buttons are not too attractive

Possible fix

No response

Steps to reproduce

1. Make buttons UI more attractive

Context

There is a shadow bug and the button UI is not attractive.

Additional information

No response

I am getting white screen whenever I click on servlet pages like books available and admin login

THIS ISSUE IS POSTED AS A COLLEGE ASSIGNMENT ON BAD CODING SMELLS AND REFACTORING TECHNIQUES. PLEASE CLOSE THE ISSUE IF IT IS OF NO USE.

Hi shashirajraja,

I hope this message finds you well. After reviewing the Address class in your codebase, I wanted to propose a potential improvement and suggest incorporating the "Remove Setting Method" refactoring technique.

Why Refactor?

Encapsulation and Cohesion: The current class primarily acts as a data holder, and adding meaningful behavior to the class can enhance encapsulation and cohesion.
Maintainability: By introducing constructor-based initialization and removing setter methods, you improve the class's predictability and make it easier to maintain.
Avoiding Redundancy: Implementing methods like equals(), hashCode(), and providing a custom toString() can contribute to a cleaner, more organized design.
Refactoring Proposal:

import java.util.Objects;

public class Address {
    private final String addressLine1;
    private final String addressLine2;
    private final String city;
    private final String state;
    private final String country;
    private final long pinCode;
    private final String phone;

    public Address(String addressLine1, String addressLine2, String city, String state, String country, long pinCode, String phone) {
        this.addressLine1 = addressLine1;
        this.addressLine2 = addressLine2;
        this.city = city;
        this.state = state;
        this.country = country;
        this.pinCode = pinCode;
        this.phone = phone;
    }

    // Additional methods for better functionality
    public String getAddressSummary() {
        return String.format("%s, %s, %s, %s, %s", addressLine1, addressLine2, city, state, country);
    }

    // Implementing equals() and hashCode() for better object comparison
    @Override
    public boolean equals(Object o) {
        if (this == o) return true;
        if (o == null || getClass() != o.getClass()) return false;
        Address address = (Address) o;
        return pinCode == address.pinCode &&
                Objects.equals(addressLine1, address.addressLine1) &&
                Objects.equals(addressLine2, address.addressLine2) &&
                Objects.equals(city, address.city) &&
                Objects.equals(state, address.state) &&
                Objects.equals(country, address.country) &&
                Objects.equals(phone, address.phone);
    }

    @Override
    public int hashCode() {
        return Objects.hash(addressLine1, addressLine2, city, state, country, pinCode, phone);
    }

    // Additional methods as needed

    @Override
    public String toString() {
        return "Address{" +
                "addressLine1='" + addressLine1 + '\'' +
                ", addressLine2='" + addressLine2 + '\'' +
                ", city='" + city + '\'' +
                ", state='" + state + '\'' +
                ", country='" + country + '\'' +
                ", pinCode=" + pinCode +
                ", phone='" + phone + '\'' +
                '}';
    }
}

By removing the setter methods, the class becomes immutable, which has several advantages, including improved thread safety and reasoning about the state of objects.

Feel free to incorporate this suggestion and reach out if you have any questions or need further clarification.

The Webpage Is Very Much Responsive On Devices Having Small Screen Sizes But The Only Problem Is That The Background Image Of The User Interface Is Getting Replicated Rather Than Getting Fit To The Device Screen

want to work on non coding part of this repository

Detailed description

Would like to improve the look of the buttons , improve font , alignment of headings, and better colour combinations of the website

Context

Can improve the user experience alot

Possible implementation

No response

Additional information

No response

Need to add a CSS file.
Need to declutter the files by removing the internal styling from each file and storing them in a single style.css file.

Can you please tell how to deploy java web application with database on github?
And also which database you are using?

Hi @shashirajraja .

while packing using mvn package from Jenkins, only the WebContent folder is packing under the created war file and while logging in getting servlets not found error.
could you please help me to pack all the folders and files from the given repository?