todoist's People
todoist's Issues
Comments go like /* <comment here> */
Line 60 in 455d6ca
Write a proper comment or get rid of this
Line 142 in 455d6ca
Move globals to the top
Line 44 in 455d6ca
How to refactor selects
I think this is where you were saying u dint refactor because you could only access them via a callback, what I would do is
function selectTasksFromDB(query, callBack) {
result = [];
db.transaction(function (tx) {
tx.executeSql(query, [], function(tx, rs){
for(var i=0; i<rs.rows.length; i++) {
var row = rs.rows.item(i)
result[i] = { id: row['id'],
name: row['name']
}
}
callBack(result)
}, errorHandler);
}
And then use this function wherever I want and If I want different processing on the result I pass it as a callBack function
Line 472 in 455d6ca
What is this ">" and "j" appending to table names ?
Line 271 in 455d6ca
Name could be consistent with create, update etc
Line 136 in 455d6ca
More readable function name and values for 1,2,3
Line 207 in 455d6ca
The library should be handling this case, check it out
Line 254 in 455d6ca
Use a css class, dont define css here, same in other parts of code
Line 281 in 455d6ca
Can select from db be refactored to function with signature needing an argument ?
Line 317 in 455d6ca
tdate > tDate and giving more verbose name would be better, same for some other parts of code
Line 218 in 455d6ca
more readable names, no target1 2 3
Line 353 in 455d6ca
When will this block be executed ?
Line 167 in 455d6ca
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.