shaunbaker / predictionio-node-sdk Goto Github PK

hi, at first thanks for this sdk!

i think using POST for retrieving recommendations is the wrong method according to the documentation (the same for similarity). using POST results in a 404 wich is not detected by the tests as there are no checks for correct statusCodes.

var prediction = require('predictionio')({
    key: 'xxx',//add valid key here
    baseUrl: 'http://127.0.0.1:8000/'
});
prediction.users.get('nonexistinguserid', function (err, res) {
        console.log('err', err);
        console.log('res', res);
});

Results in

null
{}

This is because the request is structured as http://127.0.0.1:8000//users/nonexistinguserid.json with double // and the response of the server is

{ 
  //...
  links: {},
  text: 'Your request is not supported.',
  body: {},
  files: {},
  buffered: true,
  headers: 
   { 'content-type': 'text/plain; charset=utf-8',
     'access-control-allow-origin': '',
     connection: 'close',
     'content-length': '30' },
  header: 
   { 'content-type': 'text/plain; charset=utf-8',
     'access-control-allow-origin': '',
     connection: 'close',
     'content-length': '30' },
  statusCode: 404,
  status: 404,
  statusType: 4,
  info: false,
  ok: false,
  redirect: false,
  clientError: true,
  serverError: false,
  error: 
   { [Error: cannot GET //users/14.json?pio_appkey=xxx (404)]
     status: 404,
     method: 'GET',
     path: '//users/14.json?pio_appkey=xxx'
  }
  //...
}

any improvement in the near future for node.js in the docs online? noticed md file has some information but surprised to not see it online.

A couple of things...

Your documentation here https://github.com/ShaunBaker/PredictionIO-Node-SDK/blob/master/DOCS.md#fetch-user-recommendations

Is missing the pio_engine param. This is required and I didn't realize this until I used the call back method.

Which leads to the second issue, is there .then().catch() support? I see that on the items.recommendation function if there's an error you call defer.reject(err). That stops the process, but the error message is not accessible. Whats the best way to handle errors when using the promise approach?

There is a new version of PredictionIO, 0.8, with a complete new API.
This module no longer works with that version.

Thank you for your great work!

Do you expect this repository to become the 'official' PredictionIO Node SDK?

Kind of annoying to have to take sane data and run it through a prefixer, then run data that comes back through a prefix removal fn. Why does predictionIO do this? I've never seen anything like it in other dbs

Hi,
Thanks for starting this project.
I did a npm install for this SDK couple of days back and the version I have is 0.0.4.The implementation of prediction.items.similarity takes in parameter for pio_uid. However, as per the PredictionIO API endpoint specs, this should be pio_iid.

Can you please confirm?

Thanks,
Prakash