Include Respond.js about aight HOT 6 CLOSED

Sounds interesting. I'll look into it!

from aight.

I can help, if you can explain me how to include a third party lib in aight.js source :)

from aight.

Thanks! I would recommend working in the v2 branch, as that's where all of the new hotness lives. The basic steps are:

1. Check out Respond.js as a git submodule in the lib directory
2. Add the new respond.js path (e.g. lib/respond.js/respond.js) to the Makefile
3. Make sure you have UglifyJS installed, e.g. npm install -g uglify-js.
4. Run make clean all to rebuild the aight.js and aight.min.js files.
5. Test away!

I'm considering improvements to the build process in #44 if you have any thoughts.

from aight.

I have added Respond.js and made the necessary changes. Now do I need to include tests? If so, how should I proceed?

from aight.

Happy new year, and thanks for this. Tests are weird for aight because most of them need to happen in IE8 and 9. I'm looking into automated Selenium tests, but it'll be a while before I get these set up. If Respond.js has its own tests, as both the ie8 and dom4 libraries do, then I'd say they're good enough for now. Could you file a PR to merge into v2, please?

from aight.

Happy new year to you too! Yes I am filing the PR now!

from aight.