shawnmcknight / react-scrollbar-size Goto Github PK

Wrong export of ScrollbarSizeChangeHandlerParams and ScrollbarSizeProps that causes Declaration or statement expected error.

It should look like this:

import ScrollbarSize, { ScrollbarSizeChangeHandlerParams, ScrollbarSizeProps } from './ScrollbarSize';
export { ScrollbarSizeChangeHandlerParams, ScrollbarSizeProps };
export default ScrollbarSize;

• The issue is present in the latest release.
• I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

My project fails to load.

Expected Behavior 🤔

It should load.

Steps to Reproduce 🕹

Steps:

1. Install
2. Import and use ScrollbarSize and ScrollbarSizeChangeHandlerParams
3. Run project

Context 🔦

I'm simply trying to use it.

Your Environment 🌎

I forked the repo and created a fix. If you want me to create PR I'll gladly do so. Just let me know which branch to merge.

I tried installing and building many times, but I can't get the webpack2 build to succeed:

ERROR in ../node_modules/react-scrollbar-size/ScrollbarSize.js
Module not found: Error: Can't resolve 'lodash/throttle' in '..\node_modules\react-scrollbar-size'
 @ ../node_modules/react-scrollbar-size/ScrollbarSize.js 39:16-42
 @ ../node_modules/react-scrollbar-size/index.js
 @ ../node_modules/material-ui/Tabs/Tabs.js
 @ ../node_modules/material-ui/Tabs/index.js
 @ ../node_modules/material-ui/index.es.js
 @ ./components/Welcome.js

I verified that NPM installs lodash into node_modules and it does have throttle exported from index.js.

Using Node 8 LTS (8.9.3) and NPM 5.5.1. This is probably some configuration mistake, and I will post here if I manage to solve it - might be useful to keep this issue around in case someone else has the same problem.

A picture worth a thousand words.

@shawnmcknight shawnmcknight Please, can we do something about it 🙏 ?

P.S. @sghall Great resonance project by the way 👏

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: Cannot find preset's package (:onlyNpm)

• The issue is present in the latest release.
• I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Dependabot badge is reporting inactive even though dependabot is activated in the repo. Tracking issues found at dependabot/dependabot-core#1912 and dependabot/dependabot-core#1960.

Expected Behavior 🤔

Dependabot badge should report active since it is enabled in the repo.

Context 🔦

Very minor issue. It would be good to not give a misconception that Dependabot is not actively monitoring this repo. However, other badges exist to show dependency state so it would still show properly.

When adding material-ui (v1 beta) to a project, I get an error...

[email protected] requires a peer of lodash@^4.17.0 but none was installed.

My project is still using lodash v3, and upgrading lodash would be a pretty crazy effort.

Would it be possible to reduce the lodash version required by react-scrollbar-size? I think that throttle worked the same in lodash v3.

Or, alternately, how about using a regular dependency (instead of peerDependency) for the one function needed: lodash.throttle?

Thanks :)

From React 17 this library won't work if this is not solved. Any change this can be fixed?

Is there any change you can declare react as a peer dependency? Otherwise this causes the dreaded https://facebook.github.io/react/warnings/refs-must-have-owner.html error when used in a larger project.

Projects that use React 16 could use this if the peer dep resolver was changed

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• Update react monorepo (@types/react, @types/react-dom)
• Update babel monorepo (@babel/cli, @babel/core, @babel/node, @babel/preset-env, @babel/preset-react, @babel/preset-typescript)
• Update dependency @types/node to v18.18.9
• Update dependency eslint to v8.53.0
• Update dependency eslint-plugin-import to v2.29.0
• Update dependency eslint-plugin-jsx-a11y to v6.8.0
• Update dependency parcel to v2.10.3
• Update dependency @types/node to v20
• Update dependency lint-staged to v15
• 🔐 Create all rate-limited PRs at once 🔐

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update dependency @testing-library/jest-dom to v6
• Update dependency @testing-library/react to v14
• Update dependency eslint-config-prettier to v9
• Update dependency eslint-plugin-jest to v27
• Update dependency eslint-plugin-testing-library to v6
• Update dependency fs-extra to v11 (fs-extra, @types/fs-extra)
• Update dependency prettier to v3
• Update dependency rimraf to v5
• Update dependency typescript to v5
• Update jest monorepo to v29 (major) (jest, jest-environment-jsdom)
• Update typescript-eslint monorepo to v6 (major) (@typescript-eslint/eslint-plugin, @typescript-eslint/parser)
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository