shazow / apiclient Goto Github PK

Some chromium dependencies import this project and would require the presence of valid license headers in all source files.

Trying to access any https endpoint leads to an exception. This is by design on urllib3: https://urllib3.readthedocs.org/en/latest/security.html

I just called pip install apiclient, which worked fine. But then I tried to run import apiclient but I was told ImportError: No module named urllib3. Now I see it in setup.py so I don't quite know why it wasn't installed as a dependency with pip.

Just so you're aware of this!

http://code.google.com/p/google-api-python-client/

Both yours and google's implement 'apiclient'
Not an easy fix for either you or the other package I know.

Just wanted to report it for those that attempted 'pip install apiclient' in order to get some packages working and had failures on 'from apiclient import discover'

base.py#L46 has a mysterious TODO comment:

    def _compose_url(self, path, params=None):
        # TODO: fix this, as per our conversation at Oct. 4, 2011, 05:10 UTC
        p = {self.API_KEY_PARAM: self.api_key}

        if params:
            p.update(params)

        return self.BASE_URL + path + '?' + urlencode(p)

Could you explain this to the general public (or just me, whichever) so we can think about a fix for whatever the problem is?

Hopefully it's as easy as running 2to3

  File "foo.py", line 6, in <module>
    from apiclient.discovery import build as google_service_build
  File "/home/ubuntu/environment3/lib/python3.4/site-packages/apiclient/__init__.py", line 1, in <module>
    from .base import APIClient, APIClient_SharedSecret
  File "/home/ubuntu/environment3/lib/python3.4/site-packages/apiclient/base.py", line 4, in <module>
    from urllib import urlencode
ImportError: cannot import name 'urlencode'

Do you consider a good idea to do that replacement? Since requests lib is considered a very good option to handle http/https communication, i thought it was a good feature to work on.
I'll be working in this for a personal project. If you like this idea, i can maybe send you a pull request once is done.

1.0.2 was released in October of 2011. There have been several commits since then, and a new version needs to be released to apply the changes to PyPI. I personally have been affected by the issue fixed in ee95622 when trying to use pandas functions that depend on apiclient. There are also two good PRs waiting to be merged - the addition of tests and tox would be nice, even if development isn't moving very quickly 😀

So, even if you don't merge the new PRs, could you release 1.0.3? I'm currently pip installing via github, which I'd rather not do in the long run. All it would take would be to update setup.py with the new version, CHANGES.rst with a note or two on the new release and its date, draft a release on Github, and push to PyPI.

Thanks!