Giter VIP home page Giter VIP logo

spicy's People

Contributors

fabiangd avatar furstplattner avatar sheepforce avatar

Watchers

 avatar  avatar  avatar

Forkers

theochem-jena

spicy's Issues

Writers

Molecules need to be saved to files. By Text implement writers for:

  • Molden XYZ
  • Tinker XYZ
  • Sybyl MOL2
  • PDB
  • Internal representation

Parser

We need parsers for the following file formats to the internal representation:

  • Molden XYZ
  • Tinker XYZ
  • Sybyl MOL2
  • PDB
  • Internal representation

Quantum Chemistry YAML

We need wrappers to the major quantum chemistry and MM codes. A YAML based input format should enable carrying out the majority of calculations with high level of abstraction but still the possibility to access lower level settings of underlying programs.

  • Define a "calculation type" data structure
  • Define a YAML based input format
  • Define YAML based format to abstract capabilities of underlying programs

Fragment Detection

Implement fragment detection to split molecules into subunits:

  • Distance matrix
  • Bond Bool matrix
  • Fragment merging

`parsePDB` is not parsing more than 4 bonds per atom

For exotic residues, such as the vanadium atom in 4ndg, which have more than 4 bonds, the PDB specification states, that the CONECT record for a single atom might occur more than once, if it has more than 4 bonds. This is currently not handled by parsePDB and the resulting bonds can therefore sometimes be not strictly bidirectorial. The consequence is, that a Molecule created by parsePDB can be malformed and is not passing checkMolecule.

Sanity checks of molecules not complete (`checkMolecule`)

checkMolecule is not checking if bonds are correctly bidirectorial. If a key from IntMap maps to values in an IntSet, the values in the IntSet must also be keys, mapping to the original key. This check must be implemented.

checkMolecule is also not checking if the coordinate sequence of all atoms is strictly of length 3.

XYZ parser fails with the comment line empty

I noticed that the current .xyz-parser (parseXYZ) fails to parse the molecule, as long as there is nothing on the second line (usually used for comments).

I suppose this should not crash in the first place?
As a first measure, I added a water molecule to the goldentest folder (H2O_broken.xyz) for testing this.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.