shekhargulati / strman-java Goto Github PK

isUpperCase and isLowerCase currently work by upper or lower casing the input string and comparing.

In my testing, it's a lot faster (and won't create additional strings), if instead you do something like this:

public static boolean isUpperCase(final String value) {
    for (int i = 0; i < value.length(); i++) {
        if (Character.isLowerCase(value.charAt(i))) {
            return false;
        }
    }
    return true;
}

public static boolean isLowerCase(final String value) {
    for (int i = 0; i < value.length(); i++) {
        if (Character.isUpperCase(value.charAt(i))) {
            return false;
        }
    }
    return true;
}

Just an idea. Thanks for the nice library!

Unequal is a more common word (although inequality is more common than uneqiality)

A useful library, thanks!

removeLeft and replace work in a way I wouldn't expect because they call toLower in the case-insensitive case.

For example,

Strman.removeLeft("This HAS A THIS IN FRONT", "THIS ", false)

returns "has a this in front". I would expect it to return "HAS A THIS IN FRONT".

Perhaps you could check for startsWith in a case-insensitive way, then remove the first N characters of value, where N is the length of prefix.

Strman.replace("One and two and THREE and Four", "and", "&", false)

returns "one & two & three & four". I would expect it to return "One & two & THREE & Four".

I haven't tested this, but maybe for the replace function you could copy the replace function in the String class and specify Pattern.CASE_INSENSITIVE (and maybe Pattern.UNICODE_CASE).

removeRight works in what I would call the correct way:

Strman.removeRight("Remove the END at the end", " END", false)

returns "Remove the END at the".