shepazu / audio-eq-cookbook Goto Github PK

• I think <math xmlns="http://www.w3.org/1998/Math/MathML" display="block"> would be better than using mstyle. The reason is that MathML renderers will then render the math element as block; this will also set displaystyle to true. That will also remove the need for forcing this via CSS (which I think is the reason why the MathJax's menu isn't placed correctly).

• Equation 3: I forgot to add _'s in the denominator.

   H(z) = (b_0/a_0) * (1 + (b_1/b_0)*z^-1 + (b_2/b_0)*z^-2)/ (1 + (a_1/a_0)*z^-1 + (a_2/a_0)*z^-2) text{equation 3}
  

• Maybe make the "Then compute a few intermediate variables:" section into a ul of equations? That might give it a clearer layout.

• In that list "digital filter with BLT" is missing one subscript in the first w0. (I'm not sure about the grouping of multiplication and division here but the original author will know.)

• Starting with section "FYI: The bilinear transform" there are a couple of missing groupings and subscripts.. Again, I would make most of it an ul (but I'm a sucker for lists).

  • s ← 1/( tan(w_0/2) ) * (1 - z^-1)/(1 + z^-1) text{(normalized)}
  • tan(w_0/2) = ( sin(w_0)) / ( 1 + cos(w_0)), (tan(w_0/2))^2 = (1 - cos(w_0)) / (1 + cos(w_0))
  • 1 ← ( (1 + cos(w_0)) / (1 + cos(w_0) ) ) * ( (1 + 2*z^-1 + z^-2) / (1 + 2*z^-1 + z^-2) )
  • s ← (1 + cos(w_0))/sin(w_0) * (1 - z^-1)/(1 + z^-1) = (1 + cos(w_0) ) / (sin(w_0) ) * ( 1 - z^-2)/(1 + 2*z^-1 + z^-2)
  • s^2 ← (1 + cos(w_0))/ (1 - cos(w0) ) * (1 - 2*z^-1 + z^-2)/(1 + 2*z^-1 + z^-2)

• Then with "out, and thus be left out in the substitutions above resulting in:"

  • s ← (1 + 2*z^-1 + z^-2) / (1 + cos(w0))
  • s ← ( 1 - z^-2) / (sin(w0))
  • s^2 ← (1 - 2*z^-1 + z^-2) /( 1 - cos(w0))

• the final section needs linebreaks between the equations (which changing to display="block" would do for you)

http://shepazu.github.io/Audio-EQ-Cookbook/audio-eq-cookbook.html has an error:

Hello,
the published version in branch gh-pages has an issue which makes maths not loadable in Brave browser.

https://shepazu.github.io/Audio-EQ-Cookbook/audio-eq-cookbook.html

The console prints this error.

Mixed Content: The page at 'https://shepazu.github.io/Audio-EQ-Cookbook/audio-eq-cookbook.html' was loaded over HTTPS, but requested an insecure script 'http://cdn.mathjax.org/mathjax/latest/MathJax.js?config=MML_HTMLorMML'. This request has been blocked; the content must be served over HTTPS.