Calculate intact stability about vesseljs HOT 8 CLOSED

@MrEranwe All of the required attributes are (in theory) calculated by the existing methods in Vessel and Hull.

You will have to do something like this (in a method in Vessel.prototype. vesselState will be a parameter):

var T = this.calculateDraft(vesselState);
var ha = this.structure.hull.calculateAttributesAtDraft(T);
var w = this.getWeight(vesselState);

Then find the values you need for the calculation within these three results.

from vesseljs.

I have created a dev branch. It would be nice if you make changes only to that one initially, so that we can review, test and revide the code before committing to master.

I must admit that I am not used to handling these things, but I can see that it is valuable to be able to do so. We definitely don't want to be overwriting each other all the time.

from vesseljs.

GM Solved

from vesseljs.

BM KB is misplaced, change it.

from vesseljs.

Get real VCB/TCB values from Buoyancy calculations

from vesseljs.

Since we have both Ixwp and Iywp, we should be able to calculate longitudinal and transverse GM. :-)

from vesseljs.

@MrEranwe Would you mind checking that I have made the new stability calculation method right? I replaced the placeholder calculations with values from the corrected hull calculations, and added distinction between longitudinal values and transverse values. I use waterplane Ix for BMT and GMT, and waterplane Iy for BML and GML, and set BM to BMT and GM to GMT (returning GMT, GML GMT, BML separately too). Is it OK?

from vesseljs.

Closing - we can always open a new when this is priority again.

from vesseljs.