Giter VIP home page Giter VIP logo

Comments (5)

hmgaspar avatar hmgaspar commented on July 24, 2024

Double check calculations and push master when done.

from vesseljs.

EliasHasle avatar EliasHasle commented on July 24, 2024

I took the liberty to push to master even before everything is OK. That is because I have fixed countless bugs, and everything seems to be working at least as well as before.

I have introduced a small debug tool under examples: https://shiplab.github.io/vesseljs/examples/PX121_calculations.html

Ixwp and Iywp are still a long way off. But as far as I can see, all other values look quite reasonable. I will of course continue debugging, and it will be interesting to have @MrEranwe 's work on #11 as another debug tool.

from vesseljs.

EliasHasle avatar EliasHasle commented on July 24, 2024

Status for calculations run on the block case (#11):
The calculation of wetted area ("As") does not yet account for end caps. But even when adding two times the calculated projected area (which should give an upper bound, at least approximately), the number is still much lower than the manually calculated wetted area. This suggests that there is at least one other error too, either in the calculation of wetted area or in that of projected area.
The calculation of center of bouyancy ("Cv") is broken, and returns (0,0,0).
Waterplane Ix and Iy (Ixwp, Iywp) are off by a couple orders of magnitude.
Cb is way off. I expected exactly 0.5 (not accounting for trim), and it returns 0.99725.
Submerged volume ("Vs") does not align with the assumed displacement. A bug here is probably causing the Cb problem too.
The calculated weights and drafts are very different. I would like to see how the manual weight calculation is done, as I know the automatic calculation for the hull right now is very wrong.

The rest of the calculated values are within the margin expected from the difference in accounting or not accounting for trim. (I have not checked the stability values yet.)

I will look into the problems, and try to solve them during this week.

@MrEranwe Maybe you can add manually calculated values for Ixwp, Iywp, yz coordinates for centers of gravity and buoyancy, projected area (along x axis, that is)?

from vesseljs.

EliasHasle avatar EliasHasle commented on July 24, 2024

from vesseljs.

EliasHasle avatar EliasHasle commented on July 24, 2024

Now, in dev, it almost passes the blockCase_compare_json.html test. Only the z
component of the center of submerged volume deviates signfificantly from
the hand-calculated value. It looks like more zero-offset areas are sent
to the patchColumnCalculation function than I would expect. (Potential
bug.)

I have (temporarily) introduced simpler volume and area calculations
during debugging, and will try to reintroduce the bilinear patches, as
they give higher accuracy when they work (at least for the volume, where there is a siple analytical solution to the integral).

from vesseljs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.