Comments (14)
from vesseljs.
Restructure API page according to Elias' suggestions (break classes into different headers, document all classes of the library).
from vesseljs.
Debug Hull Hydrostatics example and document it with a tutorial.
from vesseljs.
@EliasHasle, as to the ship.calculateStability()
method, how can I force it to calculate stability parameters for a draft chosen by the user, instead of using the draft derived from weight equilibrium calculations inside the calculateDraft(shipState, epsilon=0.001)
method?
from vesseljs.
In addition, is it ok to push example commits directly to the master branch? This will make them reachable through https://shiplab.github.io/vesseljs/ right away, as the dev branch can't be reached from there.
from vesseljs.
Good questions. I take the last one first. It is OK that you push commits for your own examples to the master branch, if you know what you are doing. :-) It will not be too hard to merge later.
Ship.prototype.calculateStability depends on both draft and weight, and draft depends on weight (and hull geometry). So having draft as a parameter would be misleading. We could possibly have weight (or "displacement") as a parameter, though, instead of the full ship state. The same goes for calculateDraft. I think that is cleaner, as none of those methods need to know more. But then, actually, we could have them in the hull class. I think that might be the way to go. (It could even make proper caching easier.)
What is your use case for inputting draft to Ship.prototype.calculateStability?
from vesseljs.
I am working on this example. The idea is to display some hydrostatic properties as functions of the draft, which should be controlled by the user with the gui slider on the page.
from vesseljs.
from vesseljs.
Yes, I understand. That's why the intention was to display only KB and BM, which depend on the submerged volume but not on the position of the center of gravity (as GM does). In that sense, they could be calculated as functions of the draft only.
from vesseljs.
Ok, so from the information you provided, I was able to get everything I needed from the outputs of calculateAttributesAtDraft(T): Volume of displacement, KB, BMl, BMt, LCB and LCF (https://github.com/shiplab/vesseljs/blob/master/examples/Hull_hydrostatics.html#L274). Maybe you'll still want to present those values with their hydrostatic names inside the method just to use familiar terminology to naval architects.
from vesseljs.
from vesseljs.
Ok, so I'll do it this week or the next. When I update it, should I deprecate the properties with the current terminology (Cv, xcwp, etc.) or should I leave them there? I wonder if removing them could cause incompatibilities.
from vesseljs.
from vesseljs.
@icarofonseca We shoukd have a "manual" for new examples, given that every year we expect to have students creating new examples. Let's talk about it on the october meeting. I'm closing it for now.
from vesseljs.
Related Issues (20)
- Organizing Equipment, Lines and Dynamical Matrices HOT 2
- InsertMooring general function snippet HOT 2
- Modernizing with ES6 classes, modules and smarter build process HOT 3
- Fix caching, or disable, as proposed in #87 HOT 1
- Examples: Reduce camera range to improve depth resolution
- Duplicated code HOT 1
- Compatibility for THREE.js r118 HOT 2
- Bulkhead just reaching half the Breadth of Ship
- Is it possible to create a catamaran hullform with a wave piercer? HOT 1
- Adjustments on ES6 patterns HOT 5
- Publishing Vesseljs on npm HOT 2
- Great idea HOT 1
- Clickable objects in 3d, with editable info in the GUI HOT 3
- Scale and Rotation to Derived Objects HOT 5
- Idea for Envelope Hull HOT 1
- "Rugen-Kutta" should be "Runge-Kutta"... HOT 2
- Ship3D_v2 deck geometry error HOT 2
- undefined position gives NaN CG HOT 1
- New organization of project resources HOT 2
- Ship3D_v2.js in examples: e is not defined (shows in crane pendulum example)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vesseljs.