shklar / subminimizer Goto Github PK

There must be a consistency issue in Azure when querying.
Therefore, need to ignore resources which we know were deleted in the same session.

through all code failing to find subscription or resource by ID isn't proceeded

There is no quick and easy way to get from the Analyze view to the Settings view.
We need to add such a button at the top of the page.

Hi,

By adding AI JS SDK we will get a lot of information about our application in production, including in handled exceptions.
We can also extend it and send custom events for interesting scenarios.

Thanks,
Ido.

Extend and Reserve should provide a tool tip about their action.

Currently the icon remains unchanged during these long operation (they take a few long seconds).
Please update the icon to a "wait" indication until the action completes.

Today we delete expired resources after 7 days (if the "Automatic delete" setting is selected).
This number should be defined in the settings.

Some of the resource types currently fail auto deleting.
Need to investigate.

There should be a radio button like experience where the user can choose to view :

1. Only their owned resources
2. Only unclaimed resources
3. All resources

The filtering should be done in the client side as much as possible to allow a smooth experience.

Should only reset the resources for the requested subscription of course.

Allow the user to define the expected period upfront up to some maximum limit (defined by the subscription owner)

We need to make the Reset Resource button available to all users, and not only the admin. We should call it “Release Resource”.
However, the user can only reset a resource (the button visible), if he is the claimed owner of that resource. You can’t release a resource claimed by someone else.
The admin of the subscription can release any resource.

@bergano65
I clicked an expired resource and it remained Expired.
The Expiration date was updated, but the status wasn't. The status should also be updated, and the "Extend" button should become greyed out so that nobody thinks about clicking it again.

Please add another column called "Statistics".
For connected subscriptions it should show the overall number of resources in that subscription and the number of expired resources.
Should look like this:
Total resources : 200
Expired : 15

neither azure sdk code nor authentication code have no exception handling

Please increase the resource name by 10 more chars.
It should be the first column and most dominant one. Therefore it should be the longest.

Some of the fields (like resource name, type and resource group) can be very long which makes the entire table become unreadable.
We need to limit each field to 20 characters and replace with "..." the extra characters.
There should be an alt text (like tooltip) with the full string.

The purpose is that the 2 buttons at the end of the row should fit in one line.

Please make sure to validate that the user is the current owner.
We do not want to allow anyone else to disconnect.

In case this is not the user, let them see the settings, but they should get some error pop up message telling them that they should contact the current owner.

Service can start using the new service identiy:
https://docs.microsoft.com/en-us/azure/active-directory/msi-overview

With this identity it can access key vault to get all required secrets during runtime

Currently all failures are redirected to the Error page which returns error code 200 (success).

Currently the confirmed owner column is the first.
Please move it after the "Owner" column.

reply to address isn't in valid addresses set for application registration. links should lead to main page with parameters designating route to subscription resources page

Change email font from “Times New Roman” to “Segoe UI”

When adding some resources under my ownership (existing resources), the Owner column get's updated, but when trying to sort by ownership they are not in place with my other resources. Only after I refreshed the page and tried to sort by owner again, all of my resources were in place.

Clicking this button will reset all the subscription resources in the following way:

1. Set "ConfirmedOwner" to false.
2. Update the expiration date to today + unclaimed resources # of days.

Add a text message near the button which explains its function.

I always get token expired when starting application

Unclaimed : 10 days
Use 30 days for a "claimed resource"
Reserve : 180 days

I think it’ll be nice to have a summary / table-of-contents in the beginning of the email with anchor links to the relevant sections, something like:

Summary
• Expired resources: 0
• Unfound resources: 18
• New resources: 30
• Valid resources: 51

We would like to add an option for a user that claims/extends a resource to provide a description for that resource.
It should be a UI element which shows the description that the user entered for that resource.
It should also support editing that description. Could be either through a dedicated modal dialog or directly in the resource list.

Specifically, resources that couldn’t be found vs. valid resources.
Also, maybe worth mentioning what are new resources (as in, new since the last report?).

Many of the buttons take a long time to complete.
In the meanwhile, the user does not understand that work is being processes and clicks again.

The cursor should change to wait until the operation completes.
This applies to the main page, the settings page and the resources page.

In order to support extending multiple resources, we should probably use an Ajax call for the particular resource rather than bring the entire list from the back end.

In particular, don't send emails in case there are only valid resources in the subscriptions.

Currently subscriptions are handled one by one, when in fact they could be parallelized

Reset Resources is a very powerful button.
We need to make sure the subscription admin does not click it by mistake.
Therefore, when it is clicked it should pop up a modal dialog explaining that:
"This will reset the expiration date and ownership information for all the resources. Are you sure?"