shoppinpal / vend-nodejs-sdk Goto Github PK

At the moment the version of the logger being used does not have the ability to set or disable log level. Newer versions of sp-json-logger have an env variable for this purpose, could be worth updating?

Often modules such as this one may need to be re-used on a hosted platform such as Parse.com and the lookup of required dependencies may not work out-of-the-box.

In such cases, its easier to let folks inject the dependencies that this module needs.

I wonder if a swagger spec can be put together for the Vend API as that could be leveraged for auto-generating client source code. My only concern would be around figuring out how to mixin any utility methods on top of such a generated file ... hmmm.

Right now if I use feature/v2 to fetch all products, it gives out an array of products.
Instead, it should blurt out whatever comes out from the Vend APIs, i.e., array of products along with min and max version numbers of the data.

This example is one of many ways in which we can change our implementation to support all versions of the Vend API. It is not a solution which fits all situations, it just happened to be a simple usecase where altering path sufficed.

Anyway, we have two implementations: fetchCustomers and fetchCustomers2 and we should spend some time to either completely remove the 0.x endpoint or come up with an elegant way to support it both for the consumers of our SDK and in our implementation.

As mentioned in #22 (diff)

It seems that the following line might be using the wrong attribute/field:

randomProduct.price = String(Number(randomProduct['supply_price']) + 10.00);

should it be using retail_price instead?

@tinker20 - since you wrote these tests, deferring this to you
cc @kamal0808