shopware5 / swaggoogle Goto Github PK

Hi,

the file ua.tpl contains a bug in this line:

https://github.com/shopwareLabs/SwagGoogle/blob/master/Resources/views/frontend/swag_google/ua.tpl#L41

the plugin does a superflous and invalid round on the ordernumber of a created order. If the ordernumber is not just a counted number (which is the default in Shopware) but is prefixed or suffixed, the round returns 0 instead of the original ordernumber.

The ordernumber is a string and not a number. Because of this, the round is superflous and incorrect.

Best Regards
mschop

Hi all,

the setting 'Allow opt-out cookie' is not working. We are using Universal Analytics but the same seems to apply to Google Analytics. The cookie is always read.

See: https://github.com/shopwareLabs/SwagGoogle/blob/master/Resources/frontend/js/jquery.google_analytics_plugin.js#L66

Expected behaviour:
The plugin should not check the do-not-track-cookie, if the setting 'Allow opt-out cookie is set to No.

Currently, e.g. with release/tag 3.0.2, the .githooks directory is part of the release tarball and thus it is also accessible after the deployment of the plugin. This is not directly critical given the .githooks directory does not (yet?) contain sensible information but it might make software security scanners yelling and you also never know what happens at forks. Thus my proposal is to add a .htaccess file to restrict the access for the .githooks directory simply.

Hi,

seems that this plugin isn't yet compatible with 5.6.0? Is it possible, to bring it to work?

best regards,
norbert

Hi,

Maybe I'm wrong but am I the only one who gets multiple tracking errors while using the version 3.1.12 of SwagGoogle plugin inside a Shopware 5.5.10 installation?
After I installed the plugin and set the configuration (Tracking ID, UA library), I cleared all caches and that stuff. When I check the tracking code with the Google Assistant extension for
Chrome, I get two tracking error, because it couldn't find the propertyID and a leading or trailing whitespace in the ID on following lines
https://github.com/shopwareLabs/SwagGoogle/blob/master/Resources/frontend/js/google_analytics.js#L28-L29
(pls ignore the http error).

It's confusing that it initializes the GA Library too, instead of just the choosen one in the plugin configuration.

best regards
Arya

Hallo,

ich habe versucht das Plugin über den Pluginmanager zu installieren. Da dies nicht funktionierte habe ich die Daten via ftp hochgeladen (…plugins/Community/Core/SwagGoogle), was ebenfalls nicht funktioniert.

Beim starten des Pluginmanagers erhalte ich folgenden Fehler:
Fatal error: Class 'Shopware_Plugins_Core_SwagGoogle_Bootstrap' not found in …/engine/Shopware/Components/Plugin/Namespace.php on line 256 503 Service Unavailable

Kann mir jemand weiter helfen?

Google empfiehlt den analytics-Code vor dem schließenden /head einzufügen. ( https://developers.google.com/analytics/devguides/collection/analyticsjs/ )
Ich verstehe warum das Javascript standardmäßig im Footer platziert wird. Jedoch macht das einbinden des GA Codes im Footer oft beim exakten Tracking Probleme.

Vielleicht wäre ein guter Kompromiss ein switch der Wahlweise in frontend_index_header oder wie bisher frontend_index_header_javascript extended.

Einen Pull-Request kann ich ggf. beisteuern.

Hello,

in one of our customer shops we encountered the following exception on an article detail page when using the SwagGoogle Plugin:
SmartyException: directory /custom/plugins/SwagGoogle/Views/frontend/index/index.tpl' not allowed by security setting in /engine/Library/Smarty/sysplugins/smarty_security.php:38

The security issue seems to be forced due to the current order of the ajax request check and the template registration in the onPostDispatch method:

We could fix this issue by changing the order of the ajax request check and the template registration:

$view->addTemplateDir($this->getPath() . '/Resources/views');

if ($request->isXmlHttpRequest()) {
    return;
}

instead of:

if ($request->isXmlHttpRequest()) {
    return;
}

$view->addTemplateDir($this->getPath() . '/Resources/views');

Could you please verify this patch solution?