shulietech / linkagent Goto Github PK

es插件，白名单功能改版后，es的只读白名单功能被玻璃出去了，现在在页面没办法配置es只读白名单

在应用上报成功之后，发起正常业务流程时，探针报空指针异常（见下图1），导致远程调用一直没有对应接口数据。现在这个问题是个阻断性问题，需要尽快解决。图1:

发起压测流量时，在被压测的应用里，也还会报类型转换异常（见下图2）。图2:

2022-05-05 12:36:56 ERROR AGENT: prepare to start agent failed.
at jdk.attach/sun.tools.attach.HotSpotAttachProvider.listVirtualMachines(HotSpotAttachProvider.java:83)
at jdk.attach/com.sun.tools.attach.VirtualMachine.list(VirtualMachine.java:146)
at com.shulie.instrument.simulator.agent.core.AgentLauncher.start0(AgentLauncher.java:132)
at com.shulie.instrument.simulator.agent.core.AgentLauncher.startup(AgentLauncher.java:249)
at com.shulie.instrument.simulator.agent.core.CoreLauncher$3$1.execute(CoreLauncher.java:201)
at com.shulie.instrument.simulator.agent.spi.impl.HttpAgentScheduler.install(HttpAgentScheduler.java:206)
at com.shulie.instrument.simulator.agent.spi.impl.HttpAgentScheduler.installLocal(HttpAgentScheduler.java:313)
at com.shulie.instrument.simulator.agent.spi.impl.HttpAgentScheduler.start(HttpAgentScheduler.java:282)
at com.shulie.instrument.simulator.agent.core.CoreLauncher$3.run(CoreLauncher.java:226)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.lang.ClassFormatError: Nest-host class_info_index 53 has bad constant type in class file sun/jvmstat/perfdata/monitor/protocol/local/MonitoredHostProvider$NotifierTask
at java.base/java.lang.ClassLoader.defineClass2(Native Method)
at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1108)
at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:206)
at java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:759)
at java.base/jdk.internal.loader.BuiltinClassLoader.findClassInModuleOrNull(BuiltinClassLoader.java:680)
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:605)
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:579)
at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
at jdk.internal.jvmstat/sun.jvmstat.perfdata.monitor.protocol.local.MonitoredHostLocalService.getMonitoredHost(MonitoredHostLocalService.java:38)
at jdk.internal.jvmstat/sun.jvmstat.monitor.MonitoredHost.getMonitoredHost(MonitoredHost.java:172)
at jdk.attach/sun.tools.attach.HotSpotAttachProvider.listVirtualMachines(HotSpotAttachProvider.java:71)
... 14 common frames omitted

user-modules中，已实现 RocketMQ & MongoDB 等中间件的插件，但当前并未对控制台的“影子库表”开放使用。

请问当前还存在哪些使用问题或风险吗？

private EnhanceCallback pluginMaxRedisExpireTimeCallback = new EnhanceCallback() {
@OverRide
public void doEnhance(InstrumentClass target) {

        InstrumentMethod method = target.getDeclaredMethods("expire","pexpire","setex","psetex");
        method.addInterceptor(Listeners
            .of(PluginMaxRedisExpireTimeInterceptor.class));
        target.getDeclaredMethod("set","java.lang.Object","java.lang.Object","io.lettuce.core.SetArgs")
            .addInterceptor(Listeners.of(PluginMaxRedisExpireTimeInterceptor.class));
    }
};

这段代码好像只对5个方法做了过期时间，是还有其他的入口吗？

        InstrumentMethod xadd0 = target.getDeclaredMethod("xadd", "java.lang.Object", "java.lang.Object[]");
        xadd0.addInterceptor(Listeners.of(LettuceMethodClusterTestFirstSecondArgsArraySplitInterceptor.class, "Lettuce_xadd", ExecutionPolicy.BOUNDARY, Interceptors.SCOPE_CALLBACK));

        InstrumentMethod xadd1 = target.getDeclaredMethod("xadd", "java.lang.Object", "io.lettuce.core.XAddArgs", "java.lang.Object[]");
        xadd1.addInterceptor(Listeners.of(LettuceMethodClusterTestFirstThirdArgsArraySplitInterceptor.class, "Lettuce_xadd", ExecutionPolicy.BOUNDARY, Interceptors.SCOPE_CALLBACK));

        InstrumentMethod xadd2 = target.getDeclaredMethod("xadd", "java.lang.Object", "java.util.Map");
        xadd2.addInterceptor(Listeners.of(LettuceMethodClusterTestFirstSecondArgsArraySplitInterceptor.class, "Lettuce_xadd", ExecutionPolicy.BOUNDARY, Interceptors.SCOPE_CALLBACK));

        InstrumentMethod xadd3 = target.getDeclaredMethod("xadd", "java.lang.Object", "io.lettuce.core.XAddArgs", "java.util.Map");
        xadd3.addInterceptor(Listeners.of(LettuceMethodClusterTestFirstThirdArgsArraySplitInterceptor.class, "Lettuce_xadd", ExecutionPolicy.BOUNDARY, Interceptors.SCOPE_CALLBACK));

        InstrumentMethod xadd4 = target.getDeclaredMethod("xadd", "java.lang.Object", "java.lang.Object[]");
        xadd4.addInterceptor(Listeners.of(LettuceMethodClusterTestFirstThirdArgsArraySplitInterceptor.class, "Lettuce_xadd", ExecutionPolicy.BOUNDARY, Interceptors.SCOPE_CALLBACK));

这段代码中xadd(K key, Object... keysAndValues)方法被重复增强了

odule-pradar-core中的这个依赖，io.shulie:druid，远程仓库没有版本为1.2.5的包

辛苦把1.2.5的版本传到远程仓库

main分支，根据 takin-parent 项目的 pom 定义，应将 io.shulie.tro、tro-sdk 的 maven 依赖，调整为：1.0.0。

1、影子Server拦截方法缺失

拦截JedisPool的构造函数方法为5个，但JedisConstructorInterceptor中if else分支逻辑为6个
缺少拦截该构造函数如下：

  public JedisPool(final GenericObjectPoolConfig poolConfig, final String host, int port,
      final int connectionTimeout, final int soTimeout, final String password, final int database,
      final String clientName)

JedisConstructorInterceptor中已经有该构造函数的判断

2、JedisClusterConnectionInterceptor和JedisPoolGetResourceInterceptor的scopeName不统一

JedisClusterConnectionInterceptor和JedisPoolGetResourceInterceptor的逻辑相同都是根据正常数据源来匹配影子数据源
Jedis客户端执行了JedisSlotBasedConnectionHandler.getConnectionFromSlot后，再调用JedisPool.getResource就会找不到影子数据源的情况

下载了main分支的源码, mvn clean install的时候,报takin-message-sdk-pinpoint模块找不到,我看了下确实没有这个模块, 这个去哪里下载呢?

Caused by: java.lang.NoClassDefFoundError: Lorg/apache/skywalking/apm/agent/core/plugin/interceptor/enhance/InstMethodsInter;
at java.lang.Class.getDeclaredFields0(Native Method)
at java.lang.Class.privateGetDeclaredFields(Class.java:2583)
at java.lang.Class.getDeclaredField(Class.java:2068)
at org.apache.skywalking.apm.dependencies.net.bytebuddy.implementation.LoadedTypeInitializer$ForStaticField.onLoad(LoadedTypeInitializer.java:122)
at org.apache.skywalking.apm.dependencies.net.bytebuddy.implementation.LoadedTypeInitializer$Compound.onLoad(LoadedTypeInitializer.java:192)
at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$InitializationStrategy$SelfInjection$Dispatcher$InjectingInitializer.onLoad(AgentBuilder.java:3098)
... 31 more

调整url后注册正常

com.pamirs.attach.plugin.netty.job.obj.TraceTimerTask 方法增强有bug，会报空指针

tro-sdk依赖版本不正确，Takin中的版本号是1.0.0-snapshot

 <dependency>
        <groupId>io.shulie.tro</groupId>
        <artifactId>tro-sdk</artifactId>
        <version>1.15.0</version>
    </dependency>

java.lang.UnsupportedOperationException: class redefinition failed: attempted to change the schema (add/remove fields)

(DefaultModuleEventWatcher.java:163)

2021-09-08 08:44:27 [pamirs] WARN SIMULATOR: watch=1195 in module=redis-jedis single reTransform class redis.clients.jedis.Jedis failed, at index=0;total=1.
2021-09-08 08:44:28 [pamirs] WARN SIMULATOR: watch=1198 in module=redis-jedis single reTransform class redis.clients.jedis.PipelineBase failed, at index=0;total=1.
2021-09-08 08:44:28 [pamirs] WARN SIMULATOR: watch=1199 in module=redis-jedis single reTransform class redis.clients.jedis.Jedis failed, at index=0;total=1.
2021-09-08 08:44:29 [pamirs] WARN SIMULATOR: watch=1202 in module=redis-jedis single reTransform class redis.clients.jedis.PipelineBase failed, at index=0;total=1.
2021-09-08 08:44:31 [pamirs] WARN SIMULATOR: watch=1179 in module=okhttp single reTransform class okhttp3.RealCall failed, at index=0;total=1.
2021-09-08 08:44:31 [pamirs] WARN SIMULATOR: watch=1180 in module=okhttp single reTransform class okhttp3.RealCall$AsyncCall failed, at index=0;total=1.
2021-09-08 08:44:34 [pamirs] WARN SIMULATOR: watch=1130 in module=redis-lettuce single reTransform class io.lettuce.core.RedisClient failed, at index=0;total=1.
2021-09-08 08:44:34 [pamirs] WARN SIMULATOR: watch=1131 in module=redis-lettuce single reTransform class io.lettuce.core.AbstractRedisClient failed, at index=0;total=1.

“the big update” 太粗糙了

unload时不会从cache中删除Module 的ClassLoaderFactory，重新load Module时获取的ClassLoaderFactory依然是老的ClassLoaderFactory。旧的ClassLoader在unload时会卸已加载的类与资源导致后续加载资源不正常影响后续流程

如重新loade module时使用旧的ClassLoaderFactory不会加载spi规范的文件，load不正常

Could not resolve dependencies for project io.shulie.instrument.module:module-pradar-config-fetcher:jar:1.0.0: Failed to collect dependencies at io.shulie.tro:tro-sdk:jar:1.15.0: Failed to read artifact descriptor for io.shulie.tro:tro-sdk:jar:1.15.0: Failure to find io.shulie.tro:tro-web-bom:pom:4.4.0-SNAPSHOT in https://maven.aliyun.com/repository/public was cached in the local repository, resolution will not be reattempted until the update interval of aliyun has elapsed or updates are forced -> [Help 1]

release.sh文件不存在

基于main分支构建，这个坐标io.shulie.instrument.module:dependency-processor:jar:1.2 maven repo是找不到

在LinkeAgent的module-webflux模块中，是在AbstractServerHttpRequest的构造方法做增强，获取对应请求头放到ttl中。在DispatcherHandler的handleResult中做threadlocal的删除操作。

这有一个问题：reactor模型下所有的请求都是同一个线程去处理的，也就是RequestA,RequestB......都是使用同一线程去处理，在请求量大的时候会出现即使set了ttl，但是到使用的时候拿不到的情况，或者删了又被其他请求加上了的情况。导致流量的走向不正确

在 200并发压测情况下，单个应用接口生成md5 损耗在2%左右，这个方法调用比较高频，需要优化一下；
跟踪了损耗点主要在com.pamirs.pradar.InvokeContext#getDigest方法， 获取 MessageDigest 实例对象可以考虑做个单例对象

The folder name is different whit the 'pom.xml > artifactId & name'.

It doesn't look good in IntelliJ IDEA.

使用最新的主线分支代码编译的探针包,对测试应用发起几笔正常业务流量,但是远程调用列表查询一直无数据。该问题是个阻断性问题，比较着急，麻烦各位大佬抓紧时间帮忙看看怎么解决。

整个agent现在是延迟增强的，在增强完成之前可以直接在agent端拒绝压测请求吗？ 还是只能在服务端做限制不能发起压测请求？