siegeengineers / rms-check Goto Github PK

terrain_cost GRASS 10 0

The 0 is an UnknownWord. Maybe unknown words after a command can be assumed to be excessive arguments?

a lot of map scripts are written in different encodings, especially older ones. currently we run chardet on those but there's really no reason to convert them to utf8. the builtin tokens are all ascii and the game works on a byte level with custom const names anyway. with bstr we could treat non utf8 stuff as a str.

since tokens already have associated context information, we should be able to provide context-aware completions in the language server.

• Missing avoid_cliff_zone
• Missing avoid_all_actor_areas
• place_on_forest_zone should not take an argument
• Optional second argument to circle_radius is not supported
• Missing default_terrain_replacement
• Missing layer attributes
• Missing create_connect_to_nonplayer_land
• Compatibility messages are not comprehensive: eg some feature may be supported on UP 1.4 and HD

Zetnus showed a script like this:

if UP_EXTENSION #define RND_AVAILABLE
elseif DE_AVAILABLE #define RND_AVAILABLE
endif

if ALLOW_FULL_RANDOM_PLACEMENT
    if RND_AVAILABLE    /* a check for direct-placement support */
        start_random
            percent_chance 10    #define USE_FULL_RANDOM_PLACEMENT     
        end_random
    endif
endif

if USE_FULL_RANDOM_PLACEMENT
    direct_placement
endif

rms-check flags this as a potential compatibility issue. However, USE_FULL_RANDOM_PLACEMENT will only ever be defined if UP_EXTENSION or DE_AVAILABLE is defined, so this is actually fine. We could do dependency tracing of const definitions to account for this.