I often use the wait mode to learn some midi files I made of the Hanon exercises. I found that if I have two notes in a row and I accidentally play the second note first, it will show this as wrong, but when I play the correct note, it will play the first note and the second note again without me having played the second note a second time.

For example, if the notes are A, then B. If I play B first, it responds correctly and doesn't accept the note. Then, when I play B I hear the notes A played and then immediately hear B even though I didn't play B.

As a workaround, if I modify the code to set good_range and perfect_range to zero, it seems to fix the problem.

File:
src/features/player/index.ts

New values:
const GOOD_RANGE = 0
const PERFECT_RANGE = 0

Also, I love this project. It has already been amazingly helpful for me.

Hi, I was wondering what is the license for the sightread?
The description says it's open-source, but the package.json has a private: true.

First of all, I know this is quite a hard request being a dev myself (I code on TS too, maybe I could help somehow?) and very out of scope, but also an interesting thought could be made on the long term as there's nothing else like this out there:

As I read you're planning on implementing being able to play local files, what about trying an implementation of MIDI files synced with mp3 files? Kind of what Guitar Hero already before, taking MIDI for the charts and mp3 for the actual music. Keyboard Hero at its fullest.

I get this has some kind of implications that must be studied:

• Moonscraper does that work for Clone/Guitar Hero charts, but it only works for those games format. How could charts be made then? To develop an external editor its an inmense work so it's not viable, but maybe a workaround could be found?
• Performance/syncing issues, I don't know how hard could they hit.
• Not to talk about if the whole project structure already defined can handle something like this.

Sorry for the verbosity, maybe I'm just building castles in the sky but I thought it could be interesting. What's your thought on this?

summary
For folks with a library of 100+ MIDI files, manually uploaded each one is way too much effort. We can use the Filesystem access API for syncing entire folders.

Context #104

summary
Learning piano is difficult. I think if you were able to learn on advanced music that sounds fun vs. Twinkle Twinkle Little Star, as well as create a more gradual difficulty curve, the experience would be much more fun.

The idea is that instead of only hearing the notes being played on screen, what if we had a difficulty toggle that could drastically reduce the difficulty of a song. You'd then play the easier notes, but still hear the full song (similar to Guitar Hero & Rock Band). Over time you could then increase the difficulty setting until you are playing 100% of the notes.

A button to start recording audio and save in a mp3 file.

Example (time 00:27-00:28):
https://file.io/0SPtMawqws1v

The "Sheet hero" visualization looks like a great approach to familiarize beginners with sheet reading.

However, its current version is completely black (as normal sheet music :) with small letters to show the notes. So, it is kind of unappealing and still hard to read and associate notes with keys.

I would like to use it to introduce my toddlers to sheet music.

They currently have a toy piano that includes sheet music. Each note in the sheet is coded in a different color and each key in the piano has the same color, so it is easy for them to read the sheet and play the song.

It would be great if there was an option to enabled "Color notes" in "Sheet hero", so that each note is shown in a different color. That way, they would be easier to identify and learn and more appealing for children. Eventually, the would be prepared to move to the pure black sheet.

summary
Taking inspiration from sightreading.training, we should create a mode with infinite notes for practicing reading the staff.

Example:
https://file.io/XUQJmXGdb9Cd

I'll try to contribute with this issue next in my free time, but I can't say that it will be fast

Requested via reddit comment

summary
Browsers shouldn't need to download the soundfont every time it loads Sightread.
Same is true for MIDIs.

They should all have their cache headers set s.t. they can be cached for...at least a week.

I think it would be great to add support of MIDI Windsynths like https://a.co/d/8qZJhoA (I have this one).

E.g, UI for Sax could look like one from Saxplained videos:

I tried to connect my windsynth to sightread and it works, just needs a different UI. When I'll have a free time, will try to add it myself.

Kinda related to #108

summary
Some systems for teaching kids involve color coding notes on the staff instead of having them all be black. We can pretty easily add a new toggle in the SettingsPanel for enabling this. This should help folks learn to read notes faster, especially when the notes are on ledger lines.

I am trying to find a different sound for an instrument, but is very had to search.
First, the element is not keyboard friendly, like an auto-complete for example.
Also, the list is not in alphabetic order.

Eg:

It's great if our software I can have dual voice like most of Casio Piano, so for each press, we can have both sound together like piano with synth.

summary
When using Sightread on an iOS device in any visualization that includes the <canvas> based Virtual Piano, touch events don't seem to trigger any piano key presses.

Songs can't be played fully

Examples:
https://file.io/IYnWhQYRLoDo
https://file.io/XUQJmXGdb9Cd

Hi there 👋

Beautiful library. Super cool.

I just noticed that the atomEffect is not mounted, so it won't run.

You can make it run by defining the atomEffect in global scope just like you would an atom and passing to useAtom. atomEffects are atoms after all.

Have a nice day.

we already have horizontal lines for measure numbers.
we can also add them for beats.

My Casio CT S300 is recognized and works on my computer, but Sightread doesn't see it. Here is an example, showing Virtual Piano can see it but Sightread can't. Maybe I'm doing something wrong, but I don't know. I'm using the latest version of Firefox on Windows 10. Thank you for your attention.

many pianos have a function to transpose +-12 but sightread crashes when rendering a midi note from outside the normal range:

seems to happen because it tries to access a non-existent lane.

summary

In order to take full advantage of sightread, one needs a MIDI-compatible keyboard.
It would be great if SR were also compatible with acoustic instruments.
This would require using a mic and converting the raw audio to MIDI notes, which is an incredibly challenging problem.
Our best bet would likely be to use an off the shelf solution.

For example, project Magenta's Onsets and Frames JS API. It seems accurate, but we'll have to see about latency.

This app is very cool, and it would be nice to also support e-drum. What are you thoughts on it?

Error message shown is :

Unexpected chunk, expected MTrk, got Sequ

It would be good to have an optional countdown before the start of a song to give users time to get ready.

summary

Numerous folks have reached out over email requesting the ability to install Sightread to use it while offline. This includes:

• Launching freeplay/learn a song mode while offline
• Having access the soundfont
• Playing builtin and locally synced/uploaded music

summary
As of #113, we can make midi recordings in Free Play mode.

The only available options are Download MIDI, and copy as url.
This issue is about introducing a third option - download as MP3.

The ideal implementation will somehow go from the midi Uint8Array to sound bytes, without using Media Stream Record API

context

• Branched off from #110

summary
The builtin catalog in Sightread is pretty small.
It would be great to expand it for all difficulty levels.

Hello, I've wanted to make an app like this one, so I'd like to contribute. #64 seems a good feature.

summary
I have been personally upgrading Sightread's dependencies once in a blue moon.
We should automate the process with something like Renovate Bot. Ideally configured to create a monthly PR upgrading everything.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update all dependencies (@types/bun, @types/node, @types/react, clsx, eslint, eslint-config-next, fluent-ffmpeg, jotai, next, prettier-plugin-tailwindcss, react, react-dom, sharp, tailwind-merge, typescript)

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

summary
Currently Sightread has no Continuous Integration or Automated Tests.
Would be great to at least add a CI check with lint.

HI, I really appreciate your work but it is pratically impossible to play on smartphone even with max zoom out and desktop mode.
Is there a way to make it better?

The default piano soundfonts are ugly imo 😅
We can add these ones
https://www.youtube.com/watch?v=DR1W0VIPiPo

summary
When using wireless headphones, there is a noticeable delay between notes being played in th UI and hearing the notes in your headphones. We can probably mitigate it by using AudioContext.outputLatency to offset the visual and audio timings.

This will need to be handled in some mixture of the midi utils and Player class.