Giter VIP home page Giter VIP logo

Comments (7)

ViRb3 avatar ViRb3 commented on June 7, 2024 1

This looks like something we will have to surface to the config.yml file. I don't have time now, but will try to look at this soon.

EDIT: Actually, we should be able to automatically determine the team id from the certificate and pass it as an environment variable in Python. Will confirm later today if it's so trivial to fix.

from signtools.

markrassamni avatar markrassamni commented on June 7, 2024

Here is how I solved this issue when I had it

In sign.py line 373 add this:

def fastlane_register_app(account_name: str, account_pass: str, bundle_id: str, entitlements: Dict[Any, Any]):
    my_env = os.environ.copy()
    my_env["FASTLANE_USER"] = account_name
    my_env["FASTLANE_PASSWORD"] = account_pass
+   my_env["FASTLANE_TEAM_ID"] = os.path.expandvars("$FASTLANE_TEAM_ID")

In .github/workflows/sign.yml add the value to your env at line 13

    env:
      SECRET_URL: "${{ secrets.SECRET_URL }}"
      SECRET_KEY: "${{ secrets.SECRET_KEY }}"
+     FASTLANE_TEAM_ID: "${{ vars.FASTLANE_TEAM_ID }}"      

Then in your project go to Settings > Secrets and Variables > Actions > Variables
Add a key FASTLANE_TEAM_ID with the value of your team ID

You could modify the code to work with secrets if you prefer.

from signtools.

ViRb3 avatar ViRb3 commented on June 7, 2024

Pushed a fix in: SignTools/SignTools-CI@283a82b

Update your SignTools-CI and you should be good to go.

from signtools.

mgcrea avatar mgcrea commented on June 7, 2024

@ViRb3 can confirm that it works and I no longer get the same error, unfortunately signing still does fail at a later stage (at Signing with entitlements:), not sure if it is related but it does involve fastlane.

Thanks for the help&patch!

subprocess.CalledProcessError: Command '('fastlane', 'produce', 'create', '--skip_itc', '--app_identifier', 'com.foo.bar.baz.mgcrea', '--app-name', 'ST com foo bar baz mgcrea')' returned non-zero exit status 1.

from signtools.

ViRb3 avatar ViRb3 commented on June 7, 2024

There should be more detailed logs from fastlane that tell you exactly what's wrong. If I were to guess, maybe the bundle id com.foo.bar.baz.mgcrea is already taken by a different dev account.

from signtools.

mgcrea avatar mgcrea commented on June 7, 2024

There should be more detailed logs from fastlane that tell you exactly what's wrong. If I were to guess, maybe the bundle id com.foo.bar.baz.mgcrea is already taken by a different dev account.

Unfortunately the output is truncated and stops abruptly:

[21:26:31]: Creating new app 'ST com foo bar baz mgcrea' on the Apple Dev Center\n\nLooking for related GitHub issues on fastlane/fastlane...\n\nFound no similar issues. To crea
Cleaning up...

But you might be onto something about the ID being taken as I've signed with another team in the past, will retry! Thanks!

from signtools.

mgcrea avatar mgcrea commented on June 7, 2024

@ViRb3 That was it! It finally worked, thanks!

from signtools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.