Comments (7)
Without knowing more about how this fails I will have to guess that the problem is caused by a missing application icon. In the app.nsi file created the first time you run the compiler (if it does not already exist) then there is a line:-
Icon "htdocs\favicon.ico"
this icon is used for the program application icon if it is not found NSIS compiler fails. Check this and see if that is the issue, if not do you see any error messages in the console that can give the reason for the failure?
from appjs-deskshell.
This does not appear to be the reason for the failure. I have a valid favicon.ico file in htdocs. When I run the compiler as such it works.
If I rename htdocs to, say, 'deploy', and also edit the htdocs name to 'deploy' in the Exe compiler field for htdocs, the compiler fails.
from appjs-deskshell.
When you rename the htdocs directory to deploy then the app.nsi file will still be looking for htdocs\favicon.ico which is no longer there (it is now in deploy\favicon.ico). Copy favicon.ico to the same directory as app.nsi and rename it appicon.ico or similar then search in app.nsi file for
Icon "htdocs\favicon.ico"
and change it to
Icon "appicon.ico"
if you do this then you can rename htdocs as many times as you want and the compilation will no longer fail as the exe compiler can find the icon.
It might be nicer if the compiler generated the app.nsi file every time, this is certainly an option for the future but I wanted to allow people to take full advantage of nsis to customise their exe as much as they wanted so took the route of generating the file first time and then just using the file if it already exists without any modification for each subsequent change.
from appjs-deskshell.
I followed your instructions, but the compile still failed.
With 'deploy' as the htdocs name, in the app.nsi file, I tried
Icon "deploy\favicon.ico"
after copying the favicon.ico file to the same directory as app.nsi, I tried:
Icon "favicon.ico"
after renaming favicon.ico to appicon.ico in the same directory as app.nsi, I tried:
Icon "appicon.ico"
It is not a huge issue to have the htdocs directory keep the htdocs name for my project.
Thanks anyway.
from appjs-deskshell.
Well there should not be anything that is hardcoded to htdocs anywhere and if there is it would be good to fix it. What error do you get? I think I probably need to try and make sure that the error message from the compiler is probably displayed if it is not clear what actual error message is given.
from appjs-deskshell.
There's no error message. But in the output window I can see that none of the files in 'deploy' get collected/compiled, but they do get collected/compiled if named 'htdocs'. Running the EXE after a compile with 'deploy' just has the text 'File not found/'
from appjs-deskshell.
ok, unfortunately I am not sitting at my development machine right now, but I will re-create the problem locally and then push a fix out soon for this problem, there is no good reason to lock everything into the current layout and it should be easy to fix once I find out exactly what is causing it. The fact that the compilation is not showing the exact error message is also bad and needs to be fixed. I will write on this bug once I have an updated version for you to test on, hopefully in the next couple of days.
from appjs-deskshell.
Related Issues (20)
- Compiling Windows .exe stuck on compiling app.nsi HOT 12
- Chrome crashes when running the app
- Kiosk app .exe close button not working
- Use built-in webkit browser instead of using chrome HOT 1
- Portable Windows Hello World not running
- Local node_modules HOT 1
- Use Chromium instead of Chrome HOT 1
- Running Deskshell only runs a Chromium Browser HOT 1
- How to debug packaged executable? HOT 16
- Your website is broken HOT 13
- deskshell.exe source code HOT 1
- zip on website is broken
- How to Digitally sign the Package HOT 1
- Your website deskshell.org is offline... HOT 6
- socket.io.js not found HOT 1
- Downloads broken? HOT 7
- Creating an app with a static port?
- Would this work on a non-gui operating system ?
- Is this project still actively developed? HOT 2
- Nothing happens in deskshell HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from appjs-deskshell.