Comments (7)
The file picker is a bit of a hack to be honest. If I remember correctly it actually boots off a separate windows executable and passes in the parameters including a text file to write to. I have checked index.js and it does read and write in utf8 so my guess is that the executable itself is not writing the text file in utf-8 format.
from appjs-deskshell.
Just done some checking, the winfunc.nsi file is in the extension. http://nsis.sourceforge.net/Utf8Converter shows how to convert to utf8. Therefore we would need to update the following code:
FileOpen $5 "$OutPath" w
FileWrite $5 '$SelectedFile'
FileClose $5
To write out a UTF8 string instead (as it does now) an ascii string.
from appjs-deskshell.
thanks a lot, I updated the winfunc.nsi script as follows and recompiled the winfunc.exe, it works now:
!include "Utf8Converter.nsh"
Var /GLOBAL SelectedFileUTF8
${AnsiToUtf8} $SelectedFile $SelectedFileUTF8
FileOpen $5 "$OutPath" w
FileWrite $5 '$SelectedFileUTF8'
FileClose $5
from appjs-deskshell.
Great thanks a lot. Would you like to make the same change and submit a pull request for it? That way you get the credit you deserve for the fix
from appjs-deskshell.
hi @sihorton, I can not find the deskshell-win-func module in the master branch anymore, is it deprecated?
from appjs-deskshell.
Ah I am sorry I moved it. Not by laptop right now will find correct place for you this afternoon.
from appjs-deskshell.
I moved it to the deskshell-showcase repository. My idea was to move anything custom or extra to that repository and then let people choose if they want to use it or not, so the files are now located:
Thanks.
from appjs-deskshell.
Related Issues (20)
- Compiling Windows .exe stuck on compiling app.nsi HOT 12
- Chrome crashes when running the app
- Kiosk app .exe close button not working
- Use built-in webkit browser instead of using chrome HOT 1
- Portable Windows Hello World not running
- Local node_modules HOT 1
- Use Chromium instead of Chrome HOT 1
- Running Deskshell only runs a Chromium Browser HOT 1
- How to debug packaged executable? HOT 16
- Your website is broken HOT 13
- deskshell.exe source code HOT 1
- zip on website is broken
- How to Digitally sign the Package HOT 1
- Your website deskshell.org is offline... HOT 6
- socket.io.js not found HOT 1
- Downloads broken? HOT 7
- Creating an app with a static port?
- Would this work on a non-gui operating system ?
- Is this project still actively developed? HOT 2
- Nothing happens in deskshell HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from appjs-deskshell.