silvershop / silvershop-geocoding Goto Github PK

The most recent published version of this package, 1.2.3, is almost 2 years old and has a dependency on the old "burnbright/silverstripe-shop": "*" which causes a duplicate install of SilverStripe Shop for any module that includes silvershop/silvershop-geocoding as a dependency.

Please publish a new version based on the latest commit to fix this.

Hello
just uploaded SilverStripe 4.5.2 to the real host (PHP 7.3) and got a server error (if not logged in to Silverstripe admin)

[2020-06-25 17:03:15] error-log.ERROR: Uncaught Exception Error: "Call to undefined method Geocoder\Model\AddressCollection::toArray()" at /home/korjik5/baybuckwheat.co.nz/vendor/silvershop/geocoding/src/Extensions/GeocodedUserInfo.php line 43 {"exception":"[object] (Error(code: 0): Call to undefined method Geocoder\Model\AddressCollection::toArray() at /home/korjik5/baybuckwheat.co.nz/vendor/silvershop/geocoding/src/Extensions/GeocodedUserInfo.php:43)"} []

i had to comment line 43

FreeGeoIp provider has been unreliable, so I needed to remove it from default list.

We could implement a cache of bad providers. In other words, disable a provider when it it becomes slow/unavailable on subsequent requests. We would need to average failures over a few requests to make the decision on when to turn off a service, as you don't want to disable a service because of a one-off slow request.

Geocodeded data could be fetched when needed, instead of on first request. This will move the issue elsewhere.

We also need logging to tell us when providers fail. This is important to know, so sites can be updated accordingly.

Silverstripe 4 silvershop is using this and the thirdparty service doesnt work or has been shutdown.

If geocoding can't complete for reasons unrelated to code, it's annoying to get lots of exception messages.

We could instead log something quieter, which perhaps ends up in application logs for later analysis.

Could you please add the module to scrutinizer? https://scrutinizer-ci.com/g/new. We're keeping track of all modules we use on our contributions dashboard (github-dashing.herokuapp.com), and I've added scrutinizer quality and coverage scores there. Doesn't require any config, just four clicks. You'll have to click "Schedule inspection" for the first run, after that it should kick off automatically on commits.

There's banners you can copy paste into your README if you want. Also, if you feel like it, you could also add me as a collaborator :) There's a "Add collaborators to your repository" option on the homepage.

We're experimenting with a more fine tuned config, including code coverage running on travis, but that's not really to roll out yet (https://github.com/stojg/silverstripe-timeline). Happy to hear feedback and get help of course :)