Embed and fetch fixes about external-videos HOT 19 CLOSED

OK, I've just pushed a new release to wordpress - probably worth testing, just in case.

from external-videos.

Well, it seems to cause trouble on my Website

from external-videos.

???!!! oh wow. I just woke up here, was up til 3am workin on it.

Never saw this kind of thing before, though, that seems like maybe a cache error? It's a linux install? No js? Also, I wonder which version of PHP, mySQL, etc.

from external-videos.

Notice how it's version 4.3.7 - I just upgraded and it's fine now. Need to be aware of this though.

from external-videos.

from external-videos.

This is the kind of "unwrapped" admin notice i was getting last night before i cleared the errors. Thought it was fixed :-(... Sad to see it again!

from external-videos.

FWIW it works on my local site, so I don't know why it wouldn't in the released version.

from external-videos.

Hm and i remember there was that github syncing question before. Maybe try to re-push it to SVN, after you're sure it's the working version?

from external-videos.

Do you have a production site with external-videos on it that you can test on also?

from external-videos.

Your last commit is definitely there e0c6571 - you can check here https://plugins.svn.wordpress.org/external-videos/tags/1.0/

from external-videos.

OK, it had something to do with the existing youtube video credentials I had already stored. After removing the account and re-adding it, it now works just fine.

from external-videos.

I'll write a blog post about it - nice work and congratulations on publishing it - is this your first wordpress plugin?

from external-videos.

http://gingertech.net/2017/01/14/annual-release-of-external-videos-plugin-weve-hit-v1-0/

from external-videos.

Thanks - yes it is my first.

With the issue you reported I'm thinking, maybe new issue and PR. I'll add an isset check to each existing "authors" array key, to be sure they're there and set them if not. Similar to the options init.

This could also throw an error on the settings screen to tell people to update their author settings with missing keys (different per host, of course)

from external-videos.

re: production site
yes I do have it up on the Kiteboat site, with Vimeo and Youtube accounts

from external-videos.

phooey! i named the plugin repo icons wrong :-/ . The svg is right... but it does not seem to take precedence over the pngs as anticipated. i guess the icons will have to wait for 1.1! that'll motivate me

from external-videos.

https://project.kiteboat.com/external-videos/ 404s

from external-videos.

ah yes - they use the slug rewrite and that's a hard coded link.
I just fixed it

But maybe i also need to do a PR for "Post Type Archive Link" plugin which isn't working :-)

from external-videos.

Nice! Sure, I'll do v1.1 tomorrow if necessary

from external-videos.