New Vimeo API about external-videos HOT 9 CLOSED

Go ahead - pull requests welcome!

from external-videos.

Thanks Silvia. Quick question - reading thru Vimeo API docs now. Terminology is a bit different...
Do their "Client ID" and "Client Secret" correspond to developer_key and secret_key in the plugin settings, respectively?

from external-videos.

Yes. Note that there's an old vimeo_library.php file in the repo which you will want to replace with a new library from vimeo.

from external-videos.

Thanks - working with the new library now. Going through all the parameters to be sure the API call is getting the right ingredients - some things have definitely changed. For example there's no function "call" anymore...

from external-videos.

silvia -
dammit! :) How do I overwrite my fork with your current master from within the browser interface?

from external-videos.

What are you trying to do? You might need command line git commands... but it sounds to me like you created a fork and want to undo some commits?

from external-videos.

oh - i had forked from version 0.25 a few months ago, and since then you merged my pull request. For this new fork i just wanted to start from your current version.

What i did just now is delete my repository and reclone from your master. But in the future I'd like to know how to keep my clone up to date, so i'm not constantly deleting it

from external-videos.

OK a preliminary Vimeo API version is ready to test.

1. This version only makes authenticated calls to Vimeo, so the author data now requires an additional predefined auth token allowing the user to embed their own videos on their own site. (If people use your plugin to embed other people's videos on their sites, it may be desirable to have the option to do unauthenticated calls - see here.) Anyway for now, any existing Vimeo author data must be deleted and re-entered - currently there's no way to edit an existing author's secret keys. The new field necessary is called a Personal access token, in addition to the Client ID and Client secret. I guess the plugin should check if the "Personal access token" exists for any existing Vimeo author, and throw an alert message if author data needs to be re-entered, but i haven't written that in.
2. The vimeo library in the plugin is modified from the stock library. The new Vimeo php library unfortunately does not form some parts of its own requests properly, i've got an issue open with them on github. The issue: GET requests can return a huge amount of data for a huge number of videos. Vimeo recommends filtering the results, so the request only returns the fields we need. Theoretically the fields desired should be passed as a request parameter (a comma-separated string, or possibly a nested array), but whether you pass a string or an array, the parameter gets encoded incorrectly and the desired fields are not returned. I have hacked the library to simply append a correctly-formatted string of desired fields to the request after encoding, and the request works. If Vimeo repair their library i should probably un-hack ours :)
3. My client requested that the source and author attribution that the plugin automatically adds to post_content be optional, so i've made a setting option for this.

from external-videos.

Your patches landed and I will do a release today

from external-videos.