simonharmonicminor / java-useful-utils Goto Github PK

Try.get method might be confusing because the signature does not tell that it can throw EmptyContainerException. It is better to provide users orElseThrow() variation with zero arguments.

Enhance monad to get the exception that caused an error if needed.

All map, filter, flatMap, and similar operations should be transmitted into separated interfaces.

The secondary constructor ImmutableHashSet(Iterable<T>, boolean needsCloning) has become so tricky, that's it's hard to continue to maintain it. Besides, the profit of its "optimizing" is questionable. So, this constructor has to be deleted.

The secondary constructor ImmutableTreeMap(SortedMap<K, V>, boolean needsCloning) has become so tricky, that's it's hard to continue to maintain it. Besides, the profit of its "optimizing" is questionable. So, this constructor has to be deleted.

SpotBugs is a static analyzer. Here is the installation instruction for Gradle.

list = [1, 2, 3, 4, 5, 6].
list.step(-2) suppose to return [6, 4, 2] but not [6, 4].
list.slice(0, 6, 2) suppose to return [1, 3, 5] but not [0, 3, 5]

The secondary constructor ImmutableArrayList(Iterable<T>, boolean needsCloning) has become so tricky, that's it's hard to continue to maintain it. Besides, the profit of its "optimizing" is questionable. So, this constructor has to be deleted.

ImmutableHashMap should implement equals and hashCode directly but not delegating the functionality

gradle publish task should release not only pom but all required jars (sources, javadoc, tests, app)

Checkstyle is a static analyzer for java. In order to keep the quality on a high level, it should be integrated with the project.

This config and checkstyle version 8.42 should be used.

ImmutableTreeMap should implement equals and hashCode

PairImpl should encapsulate equals/hashCode logic inside the class, but not delegate it to static procedure

If ana Java warning occurs, the gradle build command ought to fail.

AbstractImmutableCollection must implement ImmutableCollection interface and any parent collection has to extend this class. AbstractImmutableCollection must declare equals and hashCode methods as abstract

Add the proper rule to checkstyle.xml

The secondary constructor ImmutableHashMap(Map<K, V>, boolean needsCloning) has become so tricky, that's it's hard to continue to maintain it. Besides, the profit of its "optimizing" is questionable. So, this constructor has to be deleted.

Tests should also be checked by Checkstyle.

Move methods of AbstractImmutableSet to ImmutableSet interface as defaults

Add PMD plugin to build.gradle.

It would be better to explain what problems does this lib solve in the top of the file

ImmutableCollectors has unused fields CH_ID и CH_UNORDERED_ID

The master branch should be deployed to maven central automatically each time a new pull request is merged. The easies way to achieve it is to use com.bmuschko:gradle-nexus-plugin:2.3.1 plugin.

AbstractImmutableSet should provide default toString implementation

Implement ImmutableTreeMap according to hierarchy of Java Collections Framework

All immutable collections encapsulate java native mutable collections. So, when we type something like

ImmutableArrayList<String> list = ...;
Iterator<String> iterator = list.iterator();

this iterator actually belongs to java.util.ArrayList. So, that means that iterator.remove() may actually delete an element from the list. The solution is to implement UnmodifiableIterator and force immutable collections to return it

Those classes should not implement Serializable interface

• ImmutableHashMap
• ImmutableArrayList
• ImmutableHashSet
• ImmutableTreeMap
• ImmutableTreeSet
• PairImpl

Java platform serializability is hard to maintain. More than that, it is not as significant as it used to be.

Suppressing the Throwable might be critical because it could be either OutOfMemoryError or StackOverflowError. All subtypes of Error should not be caught.

Implement classes for Supplier, CheckedSupplier and Action which calculates values only for the first time and then returns cached result

Add Github codeql-analysis support to the repository

build.gradle should have runStaticAnalysis task that runs all checkstyle and pmd steps.

New release. State of the release https://github.com/SimonHarmonicMinor/Java-Useful-Utils/tree/d57559544b0f8de897233b701767b89284d7de4c

The secondary constructor ImmutableTreeSet(SortedSet, boolean needsCloning) has become so tricky, that's it's hard to continue to maintain it. Besides, the profit of its "optimizing" is questionable. So, this constructor has to be deleted.

README.md should tell that Java 8 is the minimum required version

Enhance measurment utilities to be abled to measure time in seconds

Link to badge: https://img.shields.io/badge/checkstyle-intergrated-brightgreen
Link to page by click: https://checkstyle.sourceforge.io/

AbstractImmutableList should provide default toString, equals, and hashCode implementations

Try, Lazy, Measure, ExecutionResult, and Profiler` classes should be final

Link to badge: https://img.shields.io/badge/checkstyle-intergrated-brightgreen
Link to page: https://pmd.github.io/pmd-6.35.0/pmd_rules_java.html

https://github.com/marketplace/actions/run-java-checkstyle

The new encrypted file should be uploaded to fix that

AbstractImmutableMap should provide default implementation for concatWithOverride, concatWithoutOverride and concatWith methods

The Try monad exception should explain why does it catch Exception, but not Throwable.

equals and hashCode methods should delegate calls to internal ArrayList object

The fact of throwing custom exceptions makes users build custom logic upon their catching. Java native Optional class throws NoSuchElementException. It is better com.kirekov.juu.monad to follow this path.

Move methods of AbstractImmutableList to ImmutableList interface as defaults