simonjvardy / aviation-consultancy Goto Github PK

Code Institute Milestone 1 Project - Aviation Consultancy LLC is a (fictitious) consultancy business specialising in aircraft maintenance data and regulatory compliance. I designed the website to be a showcase of the available services and a means for new customers to make contact with the business allowing project and service requests to be submitted.

Home Page: https://simonjvardy.github.io/Aviation-Consultancy/

Dockerfile 0.92% Shell 0.81% HTML 90.72% CSS 7.55%

aviation aviation-consultancy-llc bootstrap4 css3 html5 milestone-1

aviation-consultancy's Introduction

Hi there 👋 I'm Simon

🔭 I completed my Code Institute Diploma in Software Development [Distinction] in June 2021
🔭 I’m currently working on:
- Creating Hitachi Pentaho PDI E.T.L. Software data transformation scripts for Sybase ASE databases.
- Developing SQL queries for data export to Power BI for business KPI reporting dashboards in Sybase ASE 16.
🌱 I’m currently learning:
- Currently completing HackerRank challenges in Python, SQL and 30 Days of Coding.
- Udemy Online course: The Data Science Course 2021: Complete Data Science Bootcamp
- Obsidian.md to create a Personal Knowledge Management (PKM) workflow using Markdown syntax and file linking.

😇 My Github Stats:

Programming Languages

Frontend Development

Frameworks | Libraries | APIs

Version Control | Coding

Databases

Social

Documentation

aviation-consultancy's People

Contributors

Stargazers

Watchers

Forkers

code-institute-submissions singparvi adaniy sadala1989 prasadprjc tonystark2512

aviation-consultancy's Issues

!bcdn boiler plate code for Font Awesome not showing icons

Describe the bug
GitPod Bootstrp 4CDN Snippet plugin:
!bcdn emmet code was used to create the HTML boilerplate code. However, the link tags for Font Awesome included in the boilerplate code are not working correctly - the icons are not displayed.

<!DOCTYPE html>
<html lang="en">

<head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <meta http-equiv="X-UA-Compatible" content="ie=edge">
    <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.5.0/css/bootstrap.min.css">
    <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.13.0/css/all.min.css">
    <link rel="stylesheet" href="assets/css/style.css">
    <title>Title</title>
</head>

<body>


    <!-- Footer -->

    <!-- Scripts -->
    <script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.5.1/jquery.slim.min.js"></script>
    <script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.1/umd/popper.min.js"></script>
    <script src="https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.5.0/js/bootstrap.min.js"></script>
</body>

</html>

To Reproduce
Steps to reproduce the behavior:

Type !bcdn and hit the TAB key to activate the emmet code
The boiler plate code shown above is created automatically
Copy and paste a font awesome icon tag into the section

Expected behavior
The icon should be displayed as intended

Screenshots

Desktop (please complete the following information):

OS: Windows 10

Browser Firefox

Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]

OS: [e.g. iOS8.1]

Browser [e.g. stock browser, safari]

Version 79.0 [64-bit]

README.md: Various minor typos found throughout the document

Describe the bug
Typos found in the README.md document:

SEO Table of Contents sub-menu links are not formatted correctly
Deployment section refers to the old MS-1 repo name

Expected behavior
The README.md doc should refer to the correct repo name and site URL

Screenshots
SEO ToC

Deployment

Unit Testing: Homepage callout image doesn’t resize on an iPad or iPhone display

Describe the bug

Homepage callout image doesn’t resize on an iPad or iPhone display

To Reproduce
Steps to reproduce the behavior:

Go to https://simonjvardy.github.io/Aviation-Consultancy/
Click on 'Home'
See error

Expected behavior
The background image is expected to be responsive and resize automatically to an appropriate size based on the image dimensions.

Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: iPad Pro 12.9 Gen1
OS: iPadOS 13.6.1
Browser Chrome, Firefox and Safari
Device: iPhone XS Max
OS: iOS 13.6.1
Browser Chrome, Firefox and Safari

Additional context
Viewing the website using Chrome Developer tools on a desktop browser shows the site as expected when viewing different screen sizes

Unit Testing: Contact Us email addresses wrap onto a 2nd line at smaller screen sizes

Describe the bug
Contact Us email addresses wrap onto a 2nd line at smaller screen sizes

To Reproduce
Steps to reproduce the behavior:

Go to https://simonjvardy.github.io/Aviation-Consultancy/contact-us.html
Scroll down to Contact Us section
Resize the browser window below 1780px width
see the error

Expected behavior
The text wrapping IS normal behaviour but doesn't look good. The text needs to be shorter at smaller screen sizes to remain on one line.

Screenshots

Desktop (please complete the following information):

OS: OSX 10.11
Browser Firefox

Unit Testing: Homepage CTA "Contact Us Today" button difficult to see

Describe the bug
Homepage CTA "Contact Us Today" button difficult to see. The button works but merges with the background image.

To Reproduce
Steps to reproduce the behavior:

Go to 'https://simonjvardy.github.io/Aviation-Consultancy/'
See error on the homepage hero image

Expected behavior
The CTA button needs to be big, clear and visible

Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser Firefox
Version 79.0 (64-bit)

Unit Testing: Modal Contact Form doesn't close after sending the form data

Describe the bug
After entering data in all the required fields, the modal doesn't automatically close after clicking the submit button

To Reproduce
Steps to reproduce the behavior:

Go to Home page
Click on ''Contact Us Today' button
Enter valid data into the required form fields in the modal
Click 'Send'
The data is sent but the modal remains open

Expected behavior
The modal window needs to close when the send button has been clicked

Screenshots
TBC

Desktop (please complete the following information):

OS: OS X El Capitan
Browser Firefox
Version 78.0.1esr (64-bit)

Additional context
Adding the attribute data-dismiss="modal" closes the modal when the 'Send' button is clicked but the form data is not submitted so not a viable solution.

README.md Project Management section text formatting

Describe the bug
Text formatting issues in the Project Management section

Expected behavior
The README.md content font size should be consistent

Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser Firefox
Version 79.0 [64-bit]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

README.md: Wireframe Links return page error 404

Describe the bug
The Wireframes Section links to the wireframe image files are broken - the links show a page error 404.

To Reproduce
Steps to reproduce the behavior:

Go to The Wireframes section in the README.md file
Click on any of the wireframe name links
See error

Expected behavior
The linked image file should open in a new browser window

Screenshots
Image links in the wireframes Section for README.md

Webpage error

Desktop (please complete the following information):

OS: Windows 10
Browser Firefox
Version 79.0 (64-bit)

Unit Testing: The Homepage hero image opaque overlay is too dark on some monitors

Describe the bug
The Homepage hero image opaque overlay is too dark on some display monitors

To Reproduce
Steps to reproduce the behavior:

Go to https://simonjvardy.github.io/Aviation-Consultancy/index.html
Scroll to the top of the page
View the hero image of the hangar and aircraft
The image is too dark

Expected behavior
The overlay allows the text to be read clearly but can be a bit lighter to see the background image better

Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser Firefox
Version 79.0 (64-bit)

Unit Testing: Bootstrap modal popup causing background image and text to jump

Describe the bug
Bootstrap modal popup causing background image and text to jump to the right as the window opens and back to their original positions when the modal popup is closed.

To Reproduce
Steps to reproduce the behavior:

Go to https://simonjvardy.github.io/Aviation-Consultancy/
Click on 'CONTACT US TODAY' button
When the modal popup opens, the underlying image and text jumps to the right.

Expected behavior
The background image and text should remain in their original places.

Desktop (please complete the following information):

OS: Windows 10
Browser Firefox
Version 79.0 (64-bit)

Additional context
Known issue - internet searches return many results on this problem:
Adobe Support Community
GitHub: Modal may move your background to left #15229

Unit Testing: When submitting the modal form data, there is an error "405 Not Allowed" shown

Describe the bug
After creating the confirmation.html page and adjusting the index.html modal form action="confirmation.html" attribute to open the confirmation page along with the send button data-dismiss="#confirmation" link, when testing the send button a blank page opens with the error code "405 Not Allowed"

To Reproduce
Steps to reproduce the behavior:

Go to https://simonjvardy.github.io/Aviation-Consultancy/
Click on 'CONTACT US TODAY'
Enter valid data for every form input field
Tick the consent tick box
CLick the "Send" button
A blank page opens with the error message

Expected behavior
After clicking the "Send" button, the user should be taken to the confirmation.html page

Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser Firefox
Version 79.0 (64-bit)

Unit Testing: Contact Us modal form does submit data correctly but there is no confirmation to the user

Describe the bug
Contact Us modal form does submit data correctly but there is no confirmation to the user that anything has happened or if it worked

To Reproduce
Steps to reproduce the behavior:

Go to the Home page
Click on "CONTACT US TODAY" within the Call To Action jumbotron
Complete all the required fields with suitable data
Click "Send"

Expected behavior
As a user I expect that my contact request to have been send and received a confirmation that this has happened. The modal should close and I can click an "OK" buttin to return to the Home page.

Screenshots
Home Page CTA Jumbotron "CONTACT US TODAY" button