simonstadlinger / dyod_2021 Goto Github PK

Branch name "Sprint 1"
Hand in via pull request

depends on #49 to be solved

see: https://moodle.hpi.de/mod/hsuforum/discuss.php?d=43

The add segment method in chunk has to be thread safe as well

Depends on #12.

dit ding hier hig-dev/DYOD_SoSe21#1

Reproduce:

• In ValueByValueID Dictionary Segment Test replace int dictionary segment with string dictionary segment.
  Lower Bound Method does not work overloaded

https://en.cppreference.com/w/cpp/container/vector/vector (Constructor 4)

template
FixedSizeAttributeVector<uintX_t>::FixedSizeAttributeVector(const size_t size)
: _attribute_vector(std::vector<uintX_t>(size)) {}

do not use reserve.

As posted in the PR for naive table_scan, we need to change the add_segment overload to ensure it handles chunks with no value at col_id correctly.

extract the method as mentioned in the todo in tablescan.cpp

• Add (failing) tests for existing chung data structure
• Refactor data structure

Nochmal im Forum fragen, wenn nicht dann run-time exception einbauen.

Depends on #13.

• Keep in mind to write tests for correct width calculation first.

• Prefix private/protected members with _
• When deleting/inserting/retrieving elements of STL containers, always use an appropriate STL method like erase(), find(), at() etc. ...
• Use asserts where possible
• Reserve vector size when you know in advance how much space you need (can be done in initializer)
• Rename Loop Variables to more appropriate names (no i, j etc. ...)
• Use const where possible
• StorageManager add exception throwing in public methods
• Check all DebugAsserts()

as suggested by jasper in the review

Get it to compile

as suggested by jasper in the review we want to switch our itrerator based implementation and use the solution presented in class

• Enable tests beforehand. -> Make sure they are red.

• Remove c-style casts.

• Mind the concurrent access when exchanging chunks

• Keep in mind to add additional tests.

Depends on #14.

Mind test coverage.