simplifi / appnexusapi Goto Github PK

locally i'm seeing rspec failures for ruby 2.4.1, though it is on our fork.

I’ve been communicating with Appnexus about a test system with permissions for both buyer and seller sides. It does not look like this will be available.

That said, there’s now code in the test suite that is specific to the seller side that I’m unable to test fully on my end. I’m wondering if we should look into splitting this gem into two..one for the buyer side, one for the seller side?

Thoughts?

@apurvis @joshuawscott

i reviewed their changelog.

1. looks like the rate limit stuff might affect the gem generally. the way they are discussing the rate limiting doesn't seem to be what actually goes on - see code comment
2. dbg_info deprecation also affects the gem
3. other changes seem very important to users of some services that we do not use - specifically Advertiser Service, Creative VAST Service, Insertion Order Service, Line Item Service, Member Service, Tiny Tag Service, and Profile Service all have major breaking changes.