simplydo / cryptography Goto Github PK

If you type "Infinity" (without the quotation marks) in the "Number of words" input box in the Key Maker, and then click "Generate a New Key", the application will hang (Infinity is being parsed as a number instead of as a string).

How to replicate:

1. Remove the contents of the "Number of words" box (i.e., make it blank)
2. Click on "Generate a new key" (doesn't matter what's written in the big text box)

Expected behaviour: Either an error message, or a message that says "One of 1 possible 0-word permutations..."
Actual behaviour: A message that says "One of 1 possible -word permutations..." (with the number missing before "-word").

Possible fix: Define the "lastWordCount" variable in partials/phrases.html immediately (without waiting for getRandomWords() to execute). Or, don't make lastWordCount bound to the wordCount variable.