See https://medium.com/@Trott/using-worker-threads-in-node-js-80494136dbb6 and https://nodejs.org/api/worker_threads.html

Just do the hashing in a worker.

stroncium earned $80.00 by resolving this issue!

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on Issuehunt to raise funds.

Module not found: Can't resolve 'crypto-hash' when running Cypress component test, which relies on webpack-dev-server.

Any idea why?

I'm getting this warning when I run npm run watch.

I can't solve it or figure out what it means. Any help would be appreciated.

WARNING in ./node_modules/crypto-hash/index.js 7:9-22
Critical dependency: the request of a dependency is an expression

webpack compiled with 1 warning

Laravel + Vue and just added an SDK, where I am guessing this dependency came from.

Even tho md5 is not secure it's still useful in some settings. would be nice to add it or export the create function

We use this library on a project that has to support legacy web engines (connected TVs) and on Chrome 38 we get errors like

TypeError: Failed to execute 'digest' on 'SubtleCrypto': parameter 1 ('algorithm') is not an object.

By patching with

diff --git a/browser.js b/browser.js
index 0b4337488bdf198c626d6787c3ccb09222d8b171..6165eaf420fce74837f938cb40bcb2ccf07a3c9f 100644
--- a/browser.js
+++ b/browser.js
@@ -44,7 +44,7 @@ const create = algorithm => async (buffer, options) => {
 		...options
 	};
 
-	const hash = await _globalThis.crypto.subtle.digest(algorithm, buffer);
+	const hash = await _globalThis.crypto.subtle.digest({name: algorithm}, buffer);
 
 	return options.outputFormat === 'hex' ? bufferToHex(hash) : hash;
 };

we got it working

see ampproject/amphtml#4354

The #7 method mentioned here is a good 10x faster compared to the one currently being used by this library.

That's the code:

// Pre-Init
const LUT_HEX_4b = ['0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'A', 'B', 'C', 'D', 'E', 'F'];
const LUT_HEX_8b = new Array(0x100);
for (let n = 0; n < 0x100; n++) {
  LUT_HEX_8b[n] = `${LUT_HEX_4b[(n >>> 4) & 0xF]}${LUT_HEX_4b[n & 0xF]}`;
}
// End Pre-Init
function toHex(buffer) {
  let out = '';
  for (let idx = 0, edx = buffer.length; idx < edx; idx++) {
    out += LUT_HEX_8b[buffer[idx]];
  }
  return out;
}

Uppercase letters would need to be converted to lowercase though. And a Uint8Array needs to be passed to the function rather than an ArrayBuffer.

I have a foo.txt like this:

foo
bar
baz

(LF. No LF at the end.)

And I have the following script:

const { sha1 } = require("crypto-hash");
const fs = require("fs");
const path = require("path");
const crypto = require("crypto");

main();

async function main() {
  const filePath = "foo.txt";
  const buf = fs.readFileSync(filePath);
  const str = fs.readFileSync(filePath, {
    encoding: "utf8",
  });
  console.log(await sha1(buf));
  console.log(await sha1(str));
  console.log(
    await new Promise((resolve, reject) => {
      const hash = crypto.createHash("sha1");
      const input = fs.createReadStream(filePath);
      input.on("readable", () => {
        const data = input.read();
        if (data) {
          hash.update(data);
        } else {
          resolve(hash.digest("hex"));
        }
      });
    })
  );
}

When I run it 3 times I get:

PS C:\Temp> node .\hashtest.js
4c37dbe6f4897fbed62502239273902421e1ea6a
01e06a68df2f0598042449c4088842bb4e92ca75
01e06a68df2f0598042449c4088842bb4e92ca75
PS C:\Temp> node .\hashtest.js
678082bb5b423c3dec7eb593465bd2d2cfa54287
01e06a68df2f0598042449c4088842bb4e92ca75
01e06a68df2f0598042449c4088842bb4e92ca75
PS C:\Temp> node .\hashtest.js
35d9940f295a0205252456e8c808eb5f651711b1
01e06a68df2f0598042449c4088842bb4e92ca75
01e06a68df2f0598042449c4088842bb4e92ca75

The output of sha1(buf) seems to constantly change, and never match the expected result.

Sorry, I recognize this is likely not an issue with your library but I wonder if you know a way I could work around this issue:

I'm using a library (github.com/metaplex/js) which it depends on crypto-hash and it's giving me the following error during build:

Can't resolve 'crypto' in '.../node_modules/crypto-hash'

It seems my build is trying to use index.js instead of browser.js. I don't know what that is, seeing as how you are setting "browser": "browser.js", in the package.json. Is there some setting I need to adjust for my build to use the browser.js file instead of index.js?

Documentation says input can be string ArrayBuffer ArrayBufferView

Unfortunately ArrayBuffer will fail because of this line ->

// Creating a copy of buffer at call time, will be transfered later
buffer = source.buffer.slice(0);

ArrayBuffer has no property buffer, you need a view.
A simple fix would be something like->

buffer = source instanceof ArrayBuffer ? new Unit8Array(source).slice(0) : source.buffer.slice(0)

Since you're including SHA1, probably worthwhile to include in README a note about relative security for these functions. e.g. link to https://en.wikipedia.org/wiki/Hash_function_security_summary

When using an Angular app which use the @azure/cosmos and run it at Edge browser, it will hit the below error message.
“SCRIPT1028: SCRIPT1028: Expected identifier, string or number”
Clicking the error, I found the error thrown by the line 39.
After search it, found this github link:
https://github.com/sindresorhus/crypto-hash/blob/master/browser.js#L39
This code is part of the ‘crypto-hash.’

It seems that the ‘crypto-hash’ is required if using the @azure/cosmos.

I search again and found below link which indicating that Edge doesn’t support the Rest parameters (the syntax is ‘…options’)
https://stackoverflow.com/questions/53628191/edge-script1028-expected-identifier-string-or-number

Then, the issue seems to be the dead-lock status.
The Angular app use the @azure/cosmos. The @azure/cosmos required the ‘crypto-hash’. ‘crypto-hash’ use the Rest parameters. However, the Edge doesn’t support such syntax..
Therefore, the above restriction let the Angular app cannot be used in the Edge browser.

Could you please look into the issue and consider making change on '…options’ to make the 'crypto-hash' be compatible with Edge browser as well?

Appreciate it!

I'm hoping to use this library for some basic hashing functionality in my UI (per https://www.apollographql.com/docs/react/api/link/persisted-queries/#installation), but it doesn't look like this package is built to support es5.

I am hoping to understand whether or not there is any appetite to do either of the following:

1. introduce a simple build process into the generation of this package
2. re-write the primary module to be explicitly es5 compatible

I'd like to @require this lovely little library in a userscript, e.g.:

// @require https://unpkg.com/[email protected]

- but that's not possible with the (CommonJS) browser build.

There are workarounds for this with varying degrees of inconvenience and unreliability, but I thought I'd try to address it at the source first :-)

https://developer.mozilla.org/en-US/docs/Web/API/Crypto/subtle

subtle doesnt exist on http sites

Latest Edge and Safari currently don't implement the Encoding API and therefore the module won't work:

https://github.com/sindresorhus/crypto-hash/blob/master/browser.js#L17

A fallback as described here would be nice.

@sindresorhus Would you be open to HMAC support in this library? I am happy to take a shot at a PR but wanted to confirm you thought it fit in here rather than a separate library.

I tried running this library through babel, but I'm still getting an error:

If IE11 isn't supported even with Babel, could that be noted somewhere? Thanks!

am trying to use this with sveltekit but I keep getting error

Error [ERR_REQUIRE_ESM]: require() of ES Module Instead change the require of index.js to a dynamic import() which is available in all CommonJS modules

am importing this this way import { sha256 } from 'crypto-hash';

Hi! I've been working on an app that uses Apollo Persisted Queries; Unfortunately, we are a little stuck in the past and we could use support for older browsers; Are there plans to support older distributions for these types of clients? maybe a small feature in v1.3.0
https://github.com/sindresorhus/crypto-hash/tree/v1.3.0