sindresorhus / cycled Goto Github PK

Hey Sindre,

I just came across this package and noticed that cycled object cause infinite loops when being used with Array spread and for-of loops which crashes browsers. Looking at the source code it looks like it's intended.

const cycled = new Cycled([1, 2, 3]);

const foo = [...cycled]; // infinite loop
for (let i of cycled) { ... } // infinite loop

Unfortunately, I can not wrap my head around at use case for this and I found it rather surprising because you're subclassing Array but this behavior differs from an Array. Can you give me a hint?

Thanks for the great work!

The readme isn't published to npm: https://www.npmjs.com/package/cycled

You should probably publish a patch release to so people can read the docs directly on npm.

This could be useful to check values without actually switching to them:

const Cycled = require('cycled');

const cycled = new Cycled([1, 2, 3]);

cycled.current();
//=> 1

cycled.peekNext();
//=> 2

cycled.peekNext();
//=> 2

cycled.peekPrevious();
//=> 3

cycled.next();
//=> 2

cycled.peek(1);
//=> 3

// @sindresorhus