Giter VIP home page Giter VIP logo

Comments (6)

joeldenning avatar joeldenning commented on June 8, 2024

This refresh icon is kinda confusing. It shows up only after you’ve changed an import map, which is also the exact time you’d want to refresh the page, which is generally what this icon means, but not here

It's unclear which situation you're talking about - are you referring to overrides automatically applied for libraries like react when using the dev-libs option (to use react.development.js instead of react.production.min.js)? If so, then the page does need a refresh for those overrides to be applied.

from import-map-overrides.

bradydowling avatar bradydowling commented on June 8, 2024

No. I'm talking about regular old import map overrides for an import map you've specified to localhost for example.

the page does need a refresh for those overrides to be applied.

I fully understand that. And this is exactly what makes the UX confusing.

To reproduce:

  1. Apply an override for an import map
  2. The page refresh icon appears next to the Inline Override text but clicking it does not refresh the page, instead it opens the edit modal

from import-map-overrides.

joeldenning avatar joeldenning commented on June 8, 2024

I see, yeah I'm open to the reload icon becoming a button that reloads the page. Do you have interest in submitting a pull request implementing this?

from import-map-overrides.

bradydowling avatar bradydowling commented on June 8, 2024

from import-map-overrides.

bradydowling avatar bradydowling commented on June 8, 2024

Sorry, just being realistic here, I won't be able to get to this in the near future so don't wait for me to implement this if you or anyone else finds time for this.

from import-map-overrides.

joeldenning avatar joeldenning commented on June 8, 2024

I had some time today so I implemented this in e00d6d9 and released it in https://github.com/joeldenning/import-map-overrides/releases/tag/v2.4.0

from import-map-overrides.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.