Comments (9)
Right, seems I missed that little nugget of information. Does this mean that the request should support addEventListener to listen for the readystatechange? If so, the fix is fairly trivial. In src/sinon/util/fake_xml_http_request.js, FakeXMLHttpRequest.prototype needs to have the addEventListener method added, and then in readyStateChange you need to fire those events too. Awesome if you want to give it a try!
from sinon.
Thanks for the quick response :) I'll give it a go ... even though i still have no clue about the test setup in projects like these.
from sinon.
The project uses JsTestDriver http://code.google.com/p/js-test-driver/. All you need is Java. Pull down the jar file (I recommend 1.3.1, not 1.3.2), stick it somewhere, like ~/bin. Then you do java -jar ~/bin/JsTestDriver-1.3.1.jar --port 4224
. Then use a browser to go to http://localhost:4224. THEN, from the root of the project, do java -jar ~/bin/JsTestDriver-1.3.1.jar --tests all
. It's easier than it looks. You'll catch on to the syntax by looking at the existing tests. For a better cli interface and colors: gem install jstdutil
, set $JSTESTDRIVER_HOME to point to where you put the jar (the directory, e.g. ~/bin) and do jsautotest
and tests will run automatically when you save files.
Give it a shot and let me know if you have problems, I'm happy to help :)
from sinon.
Hmm, it seems the API requires to implement the Event interface http://www.w3.org/TR/DOM-Level-2-Events/events.html#Events-Event. There doesn't seem to be an implementation in Sinon for that. Any idea about something I could steal or reuse for this?
from sinon.
Sorry man, your mail drowned in my inbox :( As far as I understood from the previous description, adding addEventListener should be enough for the public interface? I might have a chance to look closer this weekend.
from sinon.
Found some more info: https://developer.mozilla.org/En/XMLHttpRequest/Using_XMLHttpRequest and http://dev.w3.org/2006/webapi/progress/
from sinon.
Christian,
I'm sorry, I should have added a comment that I have a minimal implementation by now. It seems to work fine, but I haven't added any tests, yet.
Here's what I've come up with: https://gist.github.com/995028
I'll probably not be able to cook up a good enough pull request really soon.
from sinon.
Cool, that looks like a good start. I'll see if I can add some tests and get it merged in this weekend.
from sinon.
It took some time, but I finally committed your code along with some minor modifications and tests. Mind trying the HEAD version in your project? Thanks for your effort!
from sinon.
Related Issues (20)
- Throw meaningful error message when trying to return non-objects from stub used as constructor HOT 1
- Improve error message for immutable descriptors to include link to article HOT 1
- Spies for property accessors are not automatically cleaned up
- Use sinon to mock node-mssql HOT 1
- No useRealTimers() or runAllTimers() ? HOT 1
- I can't find the CHANGELOG HOT 9
- Elaborate on "For the stubbing to work, the stubbed method cannot be destructured, neither in the module under test nor in the test." HOT 5
- Unable to install [email protected] HOT 6
- Remove unused/meaningless exports and modules from the codebase HOT 1
- Limit assertion log to a reasonable default HOT 1
- `returns` not override `callThrough` HOT 4
- `returns` clears fake's `callArgAt` HOT 5
- Discrepancy in stub construction methods HOT 4
- Feature Request: Add API support to stub a parent class constructor. HOT 4
- .rejects doesn't match documentation HOT 2
- SyntaxError: Unexpected token . -> assert(opts?.sinonXhrLib, "No XHR lib passed in"); HOT 1
- Documentation of callIds
- Cannot stub private methods in native JavaScript classes HOT 1
- Calling replaceGetter invokes the original function HOT 4
- [Node v21.7.0] Impossible to stub `fetch` HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sinon.