Comments (3)
@ahmed1hsn You are correct in pointing this out! This description is both wrong and it actually made me aware of a bug inside of Sinon. I had a look at the error message that was originally mentioned in #2530 to see what was really going on and found that it does a typeof wrappedMethod
, and that will always be undefined
as nothing has set that variable yet.
![Skjermbilde 2023-08-13 kl 23 08 40](https://private-user-images.githubusercontent.com/618076/260327660-ddfde4a5-f325-46ca-9ec2-ddda1bdc9f48.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxMjI5OTQsIm5iZiI6MTcyMjEyMjY5NCwicGF0aCI6Ii82MTgwNzYvMjYwMzI3NjYwLWRkZmRlNGE1LWYzMjUtNDZjYS05ZWMyLWRkZGExYmRjOWY0OC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzI3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyN1QyMzI0NTRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jMzBjYWU2NmIxMjY3Yjg4MDg3NWE0NWQwZTkxNjhkM2E2NTFkYjUyMjFmN2Q0NzhhMWVkNDI5ZmNkMjVjNTI4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.Rp07PMVG1XQwM1QhGwDGDUmW9GEyY9tdVrr1I09ocnQ)
Additionally, as you point out, if something has a getter, it is defined. I must have been a bit sleep deprived when writing this initially. Adding an actual reproduction case (as I could not do that in 2530) is indeed the first step 😄 And the this issue needs updating.
from sinon.
This issue does not make sense as it is, being based on an issue we could not reproduce and having some faulty assumptions.
from sinon.
@fatso83 how we can reproduce this issue? and alternatively, how can we find out that property is getter or setter if it's undefined at first place?
from sinon.
Related Issues (20)
- I can't find the CHANGELOG HOT 9
- Elaborate on "For the stubbing to work, the stubbed method cannot be destructured, neither in the module under test nor in the test." HOT 5
- Unable to install [email protected] HOT 6
- Remove unused/meaningless exports and modules from the codebase HOT 1
- Limit assertion log to a reasonable default HOT 1
- `returns` not override `callThrough` HOT 4
- `returns` clears fake's `callArgAt` HOT 5
- Discrepancy in stub construction methods HOT 4
- Feature Request: Add API support to stub a parent class constructor. HOT 4
- .rejects doesn't match documentation HOT 2
- SyntaxError: Unexpected token . -> assert(opts?.sinonXhrLib, "No XHR lib passed in"); HOT 1
- Documentation of callIds
- Cannot stub private methods in native JavaScript classes HOT 1
- Calling replaceGetter invokes the original function HOT 4
- [Node v21.7.0] Impossible to stub `fetch` HOT 4
- Remove `const sandbox = sinon.createSandbox();` from examples unrelated to `sandbox`. HOT 1
- SinonFakeServer.respondWith not working with query params on 17.0.2 HOT 5
- sinon-test is broken when using sinon v17.0.2 HOT 2
- docs: overview of compatible nodejs versions HOT 4
- Mysterious undocumented v18 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sinon.