Giter VIP home page Giter VIP logo

Comments (6)

neonstalwart avatar neonstalwart commented on August 24, 2024

one of the nice things about sinon was that it didn't have any external dependencies - at my work, every new dependency is heavily scrutinized and makes adoption of libraries difficult if they have any dependencies we're not already using. we also do not use package managers like npm - except for the ports managers provided with the os (in our case the os is freebsd).

are you sure buster provides enough value to raise the entry level for sinon by that much? i'm not saying that its definitely a showstopper for us but i'm going to have to justify it somehow so i wanted to hear your take on it.

from sinon.

cjohansen avatar cjohansen commented on August 24, 2024

The benefit is vastly improved output when assertions fail. The cost is small - sinon-1.3.0.js will bundle the dependency in a closure, so the only thing you'll notice is a slightly bigger file. On node, npm will install the dependency for you. If you get sinon for node without npm, you can simply skip the buster part, and sinon will gracefully work like before. Still worried?

from sinon.

neonstalwart avatar neonstalwart commented on August 24, 2024

it doesn't actually fail gracefully in node without buster. you're missing a try/catch around the require for buster. so... yes, still worried.

from sinon.

neonstalwart avatar neonstalwart commented on August 24, 2024

...although not too worried since you probably won't mind to add that.

from sinon.

cjohansen avatar cjohansen commented on August 24, 2024

oh my. It's supposed to fail gracefully. Thanks for finding that. I'll revise tonight.

from sinon.

neonstalwart avatar neonstalwart commented on August 24, 2024

thanks - crisis averted :)

from sinon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.