Comments (6)
one of the nice things about sinon was that it didn't have any external dependencies - at my work, every new dependency is heavily scrutinized and makes adoption of libraries difficult if they have any dependencies we're not already using. we also do not use package managers like npm - except for the ports managers provided with the os (in our case the os is freebsd).
are you sure buster provides enough value to raise the entry level for sinon by that much? i'm not saying that its definitely a showstopper for us but i'm going to have to justify it somehow so i wanted to hear your take on it.
from sinon.
The benefit is vastly improved output when assertions fail. The cost is small - sinon-1.3.0.js will bundle the dependency in a closure, so the only thing you'll notice is a slightly bigger file. On node, npm will install the dependency for you. If you get sinon for node without npm, you can simply skip the buster part, and sinon will gracefully work like before. Still worried?
from sinon.
it doesn't actually fail gracefully in node without buster. you're missing a try/catch around the require for buster. so... yes, still worried.
from sinon.
...although not too worried since you probably won't mind to add that.
from sinon.
oh my. It's supposed to fail gracefully. Thanks for finding that. I'll revise tonight.
from sinon.
thanks - crisis averted :)
from sinon.
Related Issues (20)
- Throw meaningful error message when trying to return non-objects from stub used as constructor HOT 1
- Improve error message for immutable descriptors to include link to article HOT 1
- Spies for property accessors are not automatically cleaned up
- Use sinon to mock node-mssql HOT 1
- No useRealTimers() or runAllTimers() ? HOT 1
- I can't find the CHANGELOG HOT 9
- Elaborate on "For the stubbing to work, the stubbed method cannot be destructured, neither in the module under test nor in the test." HOT 5
- Unable to install [email protected] HOT 6
- Remove unused/meaningless exports and modules from the codebase HOT 1
- Limit assertion log to a reasonable default HOT 1
- `returns` not override `callThrough` HOT 4
- `returns` clears fake's `callArgAt` HOT 5
- Discrepancy in stub construction methods HOT 4
- Feature Request: Add API support to stub a parent class constructor. HOT 4
- .rejects doesn't match documentation HOT 2
- SyntaxError: Unexpected token . -> assert(opts?.sinonXhrLib, "No XHR lib passed in"); HOT 1
- Documentation of callIds
- Cannot stub private methods in native JavaScript classes HOT 1
- Calling replaceGetter invokes the original function HOT 4
- [Node v21.7.0] Impossible to stub `fetch` HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sinon.