sir-dunxalot / ember-modals Goto Github PK

Ember 2.4.3
Ember-CLI 2.4.3

import ApplicationRouteMixin from 'ember-modals/mixins/routes/application';

Migrating from ember 1.X to 2.X I started getting this error.

To remove deprecation
http://emberjs.com/deprecations/v1.x/#toc_objectcontroller

Hi,

I've just tried out your demo on IE8 and ran into some problems. The modal opens but isn't shown correctly. The tests are failing on IE8 but I didn't look at the errors closely yet.

I'm curious to know if supporting IE8 is something that you are interested in doing. It seems like it could be possible because the modal does show (at least somewhat) on IE8. Obviously this would only be for a version that's compatible with Ember 1.13 as IE8 will go away in Ember 2.0. For me it's ok if the solution is that I need to add a polyfill for some functionality that's missing in IE8. If this is the way to go, could you point me in the right direction for which polyfills I'd need to use?

This leads me to my next question: Are you planning to release a version that works with the Ember 1.13 libraries (ember, ember-data, ember-cli, etc)? I haven't tried your library yet in my app that uses Ember 1.13 so it might even work now. I'm asking because I saw that the demo used Ember 1.10.

Thanks, Ben

Em.assert for this exists but another error is encountered first. Could use Em.warn or Em.assert.

on this page

https://github.com/sir-dunxalot/ember-modals/wiki/Usage

You state To close the modal from any controller call this.get('modal').close(). which is wrong. The code and correct way to do this is this.get('modal').hide()

Hi,
I've just started with this ember addon, but I still can't solve my problem. Component can't find closeModal action. And close button from option "showCloseButton" works.

welcome-dialog.hbs:

<h2>Welcome!</h2>
<button {{action 'closeModal'}}>Close</button>

welcome-dialog.js:

import Ember from 'ember';

export default Ember.Component.extend({
});

route template:

<button  {{action 'showModal' 'welcome-dialog' this target=modals}}>
  Show welcome with context
</button>

application.hbs

{{outlet}}

{{ember-modals}}

Error: Uncaught Error: <test-app@component:welcome-dialog::ember716> had no action handler for: closeModal

Low priority - stylesheets considered complementary, not core. For example, use any included animation in a current Firefox browser and watch the box shadow around the modal content.

and there is one in modal.js

You get this.showModal is not a function. It's redundant to have to send an action outside of the component when the component is the thing responsible for this modal.

I figured out today that this happened after updating from 0.2.1 to 0.3.4. After some debug i found that the problem happened here: https://github.com/sir-dunxalot/ember-modals/blob/master/addon/views/modal.js#L81. The problem is that outletBeingClosed is "modal" and this.get('outlet') is undefined. After going back to 0.2.1, i found that everything worked because both outletBeingClosed and the outlet property were both undefined.

I followed the steps of creating a template, setting the mixin in the application route and calling showModal from the controller. I wanted to keep diving in the code to figure out what happened but i don't know too much about ember internals to know why the call here returns undefined.

PD: My Ember version is 1.10.0 and my Ember-CLI version is 0.2.0.

In the wiki for usage, closing a modal was incorrectly using

this.get('modal').close()

instead of

this.get('modal').hide()

edited the wiki to fix the problem

Clicking the overlay does not always close the modal on iOS. Expected behaviour is the overlay closes when tapped but not pinched, etc.

ember-cli/ember-cli#4199