Comments (5)
jrfnl
commented on May 27, 2024
2
FYI: This is not a bug in the VariableAnalysis standard, but a bug in PHPCS itself as it doesn't tokenize the square bracket after a close parenthesis as T_OPEN_SHORT_ARRAY.
This is related to PHP supporting function call dereferencing which uses the same token sequence call()['key'].
This will need a fix upstream in PHPCS.
from phpcs-variable-analysis.
jrfnl
commented on May 27, 2024
2
FYI: the upstream PR has been merged and will be included in PHPCS 3.7.2.
from phpcs-variable-analysis.
jrfnl
commented on May 27, 2024
1
P.S.: @sybrew Thanks for reporting this!
from phpcs-variable-analysis.
jrfnl
commented on May 27, 2024
1
I have opened a PR in PHPCS upstream to address this: squizlabs/PHP_CodeSniffer#3632
from phpcs-variable-analysis.
sirbrillig
commented on May 27, 2024
1
Thank you @jrfnl! Since this sniff supports old phpcs versions, even if the bug is fixed upstream, I'm going to try to enable our parser to recognize this case in #268
from phpcs-variable-analysis.
Related Issues (20)
- Add validUndefinedVariableNamesInFileScope HOT 1
- Improve handling of initial values in initializers HOT 1
- UndefinedVariable first assigned in for loop, used in loop expression HOT 1
- Support of array desctructing HOT 2
- Incorrect warning for arguments to static methods that return "new static()" HOT 3
- Incorrect warning for arguments are thrown on static arrow functions HOT 1
- False-positive `UndefinedVariable` for static variable inside an anonymous function HOT 4
- Incorrect warning about redeclaration of function parameter as static variable HOT 2
- Variable $this is undefined in enum HOT 1
- Support constructor promotion with readonly properties (UnusedVariable) HOT 5
- method call called 'enum' causes an "Cannot find enum start at position" error HOT 2
- Unused function parameter in lambda function HOT 4
- Ternary operator inside arrow function HOT 3
- Incorrect warning Variable $var is undefined. HOT 6
- Undefined variable error introduced in v2.11.15 HOT 2
- Feature Request: don't report on unused parameters for deprecated functions
- Variable reported as unused on an assignment by reference HOT 2
- Assignment of an array element counts as a read
- `squizlabs/PHP_CodeSniffer` is abandoned - Replace with `PHPCSStandards/PHP_CodeSniffer` when the time is right HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phpcs-variable-analysis.