False-positive `UndefinedVariable` for static variable inside an anonymous function about phpcs-variable-analysis HOT 4 CLOSED

Ohhh... thanks. I bet it's because in that case, $providerId is, lexically, inside of a function call's arguments, except that it's inside a closure and we don't account for that. I can fix it.

from phpcs-variable-analysis.

Thanks, @sirbrillig!

In this code, $providerId is never used, only declared, so I think this sniff should mark it as unused (but not undefined). Is there a reason why that would be wrong? I wanted to check before I closed this issue in case I'm mistaken.

Yes, there was a minimum reproducible example. So Unused warning would be pretty nice.

This should be fixed by #279

I've tested your code. It works nicely for $test = (function() { static $test;}); but snippet with add_action still triggers UndefinedVariable:

add_action('test', function () {
    static $providerId;
});

from phpcs-variable-analysis.

It looks like this is happening because the code that detects if a variable is inside a list of function call arguments is incorrectly finding the static variable.

from phpcs-variable-analysis.

This should be fixed by #279

However, I wanted to ask, @shvlv: in your examples, would you expect those static variables to produce no warnings at all?

For example,

add_action('hook', static function (): void {
            static $providerId;
        });

In this code, $providerId is never used, only declared, so I think this sniff should mark it as unused (but not undefined). Is there a reason why that would be wrong? I wanted to check before I closed this issue in case I'm mistaken.

from phpcs-variable-analysis.