Incorrect EOL while getting changed files about static-review HOT 6 CLOSED

Well that's interesting, the reason I used PHP_EOL was to help when running on different platforms.

• I'll use \n instead and trim each line.

from static-review.

It can fix the problem. But also, there is another problem with the GIT under windows. With directory separators. The script can make file path and cmd like that: vendor/bin/phpcs --report=json --standard=psr2 C:\OpenServer\userdata\temp/sjparkinson.static-review/cached/vendor/sjparkinson/static-review/src/VersionControl/GitVersionControl.php

I think it's not a bug, but rather a feature of use GIT under Windows

from static-review.

For my reference here's a good SO answer on the EOL issue: http://stackoverflow.com/a/4975441

I guess the path issue is similar because we're using DIRECTORY_SEPARATOR?

from static-review.

Yes, it is.
I'm still trying to run PhpCodeSnifferReview tool on my windows env, but there is no result.
I got new errors. If I can not fix them, i will try to run this on linux env.

from static-review.

I think we should use this to split lines:

return array_filter(preg_split('/(?:\r\n|\r|\n)/', $process->getOutput()));

It will work with any combination of CR, LF, or CRLF.

from static-review.

Any updates?

from static-review.